Skip to content

Commit 968e834

Browse files
tddang-linagoratddang-linagora
committed
TW-2635 Add typing timer to receiver
1 parent c58b71f commit 968e834

File tree

5 files changed

+196
-45
lines changed

5 files changed

+196
-45
lines changed

‎lib/pages/chat/chat_app_bar_title.dart‎

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import 'package:fluffychat/domain/contact_manager/contacts_manager.dart';
1111
import 'package:fluffychat/pages/chat/chat_app_bar_title_style.dart';
1212
import 'package:fluffychat/presentation/extensions/contact/presentation_contact_extension.dart';
1313
import 'package:fluffychat/presentation/model/contact/presentation_contact.dart';
14+
import 'package:fluffychat/pages/chat/typing_timer_wrapper.dart';
1415
import 'package:fluffychat/resource/image_paths.dart';
1516
import 'package:fluffychat/utils/common_helper.dart';
1617
import 'package:fluffychat/utils/room_status_extension.dart';
@@ -252,19 +253,21 @@ class _DirectChatAppBarStatusContent extends StatelessWidget {
252253
text: L10n.of(context)!.loadingStatus,
253254
);
254255
}
255-
final typingText = room.getLocalizedTypingText(context);
256-
if (typingText.isEmpty) {
257-
return ChatAppBarTitleText(
256+
return TypingTimerWrapper(
257+
room: room,
258+
l10n: L10n.of(context)!,
259+
typingWidget: _ChatAppBarTitleTyping(
260+
typingText: room.getLocalizedTypingText(L10n.of(context)!),
261+
),
262+
notTypingWidget: ChatAppBarTitleText(
258263
text: room
259264
.getLocalizedStatus(
260265
context,
261266
presence: directChatPresence,
262267
)
263268
.capitalize(context),
264-
);
265-
} else {
266-
return _ChatAppBarTitleTyping(typingText: typingText);
267-
}
269+
),
270+
);
268271
},
269272
);
270273
},
@@ -296,14 +299,16 @@ class _GroupChatAppBarStatusContent extends StatelessWidget {
296299
if (snapshot.hasData && connectivityResult == ConnectivityResult.none) {
297300
return ChatAppBarTitleText(text: L10n.of(context)!.noConnection);
298301
}
299-
final typingText = room.getLocalizedTypingText(context);
300-
if (typingText.isEmpty) {
301-
return ChatAppBarTitleText(
302+
return TypingTimerWrapper(
303+
room: room,
304+
l10n: L10n.of(context)!,
305+
typingWidget: _ChatAppBarTitleTyping(
306+
typingText: room.getLocalizedTypingText(L10n.of(context)!),
307+
),
308+
notTypingWidget: ChatAppBarTitleText(
302309
text: room.getLocalizedStatus(context).capitalize(context),
303-
);
304-
} else {
305-
return _ChatAppBarTitleTyping(typingText: typingText);
306-
}
310+
),
311+
);
307312
},
308313
);
309314
}

‎lib/pages/chat/typing_timer_wrapper.dart‎

Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
import 'package:async/async.dart';
2+
import 'package:fluffychat/generated/l10n/app_localizations.dart';
3+
import 'package:fluffychat/utils/room_status_extension.dart';
4+
import 'package:flutter/widgets.dart';
5+
import 'package:matrix/matrix.dart';
6+
7+
class TypingTimerWrapper extends StatefulWidget {
8+
const TypingTimerWrapper({
9+
super.key,
10+
required this.room,
11+
required this.l10n,
12+
required this.typingWidget,
13+
this.notTypingWidget = const SizedBox(),
14+
});
15+
16+
final Room room;
17+
final L10n l10n;
18+
final Widget typingWidget;
19+
final Widget notTypingWidget;
20+
21+
@override
22+
State<TypingTimerWrapper> createState() => _TypingTimerWrapperState();
23+
}
24+
25+
class _TypingTimerWrapperState extends State<TypingTimerWrapper> {
26+
bool showTyping = false;
27+
late RestartableTimer timer;
28+
29+
void checkTyping() {
30+
if (!mounted) return;
31+
32+
if (widget.room.typingUsers.isEmpty) {
33+
showTyping = false;
34+
timer.cancel();
35+
return;
36+
}
37+
38+
if (widget.room.getLocalizedTypingText(widget.l10n).isNotEmpty) {
39+
showTyping = true;
40+
timer.reset();
41+
}
42+
}
43+
44+
@override
45+
void initState() {
46+
super.initState();
47+
timer = RestartableTimer(
48+
const Duration(seconds: 30),
49+
() {
50+
if (!mounted) return;
51+
52+
setState(() {
53+
showTyping = false;
54+
});
55+
},
56+
)..cancel();
57+
checkTyping();
58+
}
59+
60+
@override
61+
void didUpdateWidget(covariant TypingTimerWrapper oldWidget) {
62+
super.didUpdateWidget(oldWidget);
63+
checkTyping();
64+
}
65+
66+
@override
67+
void dispose() {
68+
timer.cancel();
69+
super.dispose();
70+
}
71+
72+
@override
73+
Widget build(BuildContext context) {
74+
if (showTyping) return widget.typingWidget;
75+
76+
return widget.notTypingWidget;
77+
}
78+
}

‎lib/pages/chat_list/chat_list_item_subtitle.dart‎

Lines changed: 25 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import 'dart:async';
22

33
import 'package:fluffychat/config/app_config.dart';
44
import 'package:fluffychat/config/themes.dart';
5+
import 'package:fluffychat/pages/chat/typing_timer_wrapper.dart';
56
import 'package:fluffychat/presentation/mixins/chat_list_item_mixin.dart';
67
import 'package:fluffychat/pages/chat_list/chat_list_item_style.dart';
78
import 'package:fluffychat/utils/matrix_sdk_extensions/matrix_locals.dart';
@@ -22,7 +23,7 @@ class ChatListItemSubtitle extends StatelessWidget with ChatListItemMixin {
2223

2324
@override
2425
Widget build(BuildContext context) {
25-
final typingText = room.getLocalizedTypingText(context);
26+
final typingText = room.getLocalizedTypingText(L10n.of(context)!);
2627
final isGroup = !room.isDirectChat;
2728
final unreadBadgeSize = ChatListItemStyle.unreadBadgeSize(
2829
room.isUnreadOrInvited,
@@ -153,25 +154,28 @@ class ChatListItemSubtitle extends StatelessWidget with ChatListItemMixin {
153154
bool isGroup,
154155
bool isMediaEvent,
155156
) {
156-
return typingText.isNotEmpty
157-
? typingTextWidget(typingText, context)
158-
: isGroup
159-
? chatListItemSubtitleForGroup(
160-
context: context,
161-
room: room,
162-
event: lastEvent,
163-
)
164-
: isMediaEvent
165-
? chatListItemMediaPreviewSubTitle(
166-
context,
167-
lastEvent,
168-
)
169-
: textContentWidget(
170-
room,
171-
lastEvent,
172-
context,
173-
isGroup,
174-
room.isUnreadOrInvited,
175-
);
157+
return TypingTimerWrapper(
158+
room: room,
159+
l10n: L10n.of(context)!,
160+
typingWidget: typingTextWidget(typingText, context),
161+
notTypingWidget: isGroup
162+
? chatListItemSubtitleForGroup(
163+
context: context,
164+
room: room,
165+
event: lastEvent,
166+
)
167+
: isMediaEvent
168+
? chatListItemMediaPreviewSubTitle(
169+
context,
170+
lastEvent,
171+
)
172+
: textContentWidget(
173+
room,
174+
lastEvent,
175+
context,
176+
isGroup,
177+
room.isUnreadOrInvited,
178+
),
179+
);
176180
}
177181
}

‎lib/utils/room_status_extension.dart‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,30 +22,30 @@ extension RoomStatusExtension on Room {
2222
return _getLocalizedStatusGroupChat(context);
2323
}
2424

25-
String getLocalizedTypingText(BuildContext context) {
25+
String getLocalizedTypingText(L10n l10n) {
2626
var typingText = '';
2727
final typingUsers = this.typingUsers;
2828
typingUsers.removeWhere((User u) => u.id == client.userID);
2929

30+
if (typingUsers.isEmpty) return '';
31+
3032
if (AppConfig.hideTypingUsernames) {
31-
typingText = L10n.of(context)!.isTyping;
33+
typingText = l10n.isTyping;
3234
if (typingUsers.first.id != directChatMatrixID) {
33-
typingText =
34-
L10n.of(context)!.numUsersTyping(typingUsers.length.toString());
35+
typingText = l10n.numUsersTyping(typingUsers.length.toString());
3536
}
3637
} else if (typingUsers.length == 1) {
37-
typingText = L10n.of(context)!.isTyping;
38+
typingText = l10n.isTyping;
3839
if (typingUsers.first.id != directChatMatrixID) {
39-
typingText =
40-
L10n.of(context)!.userIsTyping(typingUsers.first.calcDisplayname());
40+
typingText = l10n.userIsTyping(typingUsers.first.calcDisplayname());
4141
}
4242
} else if (typingUsers.length == 2) {
43-
typingText = L10n.of(context)!.userAndUserAreTyping(
43+
typingText = l10n.userAndUserAreTyping(
4444
typingUsers.first.calcDisplayname(),
4545
typingUsers[1].calcDisplayname(),
4646
);
4747
} else if (typingUsers.length > 2) {
48-
typingText = L10n.of(context)!.userAndOthersAreTyping(
48+
typingText = l10n.userAndOthersAreTyping(
4949
typingUsers.first.calcDisplayname(),
5050
(typingUsers.length - 1).toString(),
5151
);
@@ -86,7 +86,7 @@ extension RoomStatusExtension on Room {
8686
}
8787

8888
bool isTypingText(BuildContext context) {
89-
return getLocalizedTypingText(context).isNotEmpty &&
89+
return getLocalizedTypingText(L10n.of(context)!).isNotEmpty &&
9090
lastEvent?.senderId == client.userID &&
9191
lastEvent!.status.isSending;
9292
}

‎test/pages/chat/typing_timer_wrapper_test.dart‎

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
import 'package:fluffychat/generated/l10n/app_localizations.dart';
2+
import 'package:fluffychat/pages/chat/typing_timer_wrapper.dart';
3+
import 'package:flutter/material.dart';
4+
import 'package:flutter_test/flutter_test.dart';
5+
import 'package:matrix/matrix.dart';
6+
import 'package:mockito/annotations.dart';
7+
import 'package:mockito/mockito.dart';
8+
9+
import 'typing_timer_wrapper_test.mocks.dart';
10+
11+
@GenerateNiceMocks([
12+
MockSpec<Room>(),
13+
MockSpec<Client>(),
14+
MockSpec<L10n>(),
15+
])
16+
void main() {
17+
testWidgets('typing timer wrapper should stop showing typing after 30s',
18+
(tester) async {
19+
final room = MockRoom();
20+
final client = MockClient();
21+
final l10n = MockL10n();
22+
const typingText = 'typing';
23+
const notTypingText = 'not typing';
24+
const typingWidget = Text(typingText);
25+
const notTypingWidget = Text(notTypingText);
26+
when(client.userID).thenReturn('owner');
27+
when(room.client).thenReturn(client);
28+
when(room.typingUsers).thenReturn([]);
29+
await tester.pumpWidget(
30+
MaterialApp(
31+
home: Scaffold(
32+
body: TypingTimerWrapper(
33+
room: room,
34+
l10n: l10n,
35+
typingWidget: typingWidget,
36+
notTypingWidget: notTypingWidget,
37+
),
38+
),
39+
),
40+
);
41+
expect(find.text(notTypingText), findsOneWidget);
42+
expect(find.text(typingText), findsNothing);
43+
44+
when(room.typingUsers).thenReturn([User('id', room: room)]);
45+
await tester.pumpWidget(
46+
MaterialApp(
47+
home: Scaffold(
48+
body: TypingTimerWrapper(
49+
room: room,
50+
l10n: l10n,
51+
typingWidget: typingWidget,
52+
notTypingWidget: notTypingWidget,
53+
),
54+
),
55+
),
56+
);
57+
expect(find.text(typingText), findsOneWidget);
58+
expect(find.text(notTypingText), findsNothing);
59+
60+
await tester.pump(const Duration(seconds: 30));
61+
expect(find.text(notTypingText), findsOneWidget);
62+
expect(find.text(typingText), findsNothing);
63+
});
64+
}

0 commit comments

Comments
 (0)