Skip to content

Conversation

@tddang-linagora
Copy link
Collaborator

@hoangdat
Copy link
Member

hoangdat commented Nov 2, 2025

  • please add demo

@hoangdat
Copy link
Member

hoangdat commented Nov 2, 2025

  • Do we have more typing event if user still keep typing in more than 30s?

@tddang-linagora
Copy link
Collaborator Author

Do we have more typing event if user still keep typing in more than 30s?

Yes the event is still sent after 30s

typingCoolDown?.cancel();
typingCoolDown = Timer(const Duration(seconds: 2), () {
typingCoolDown = null;
currentlyTyping = false;
room!.setTyping(false);
});
typingTimeout ??= Timer(const Duration(seconds: 30), () {
typingTimeout = null;
currentlyTyping = false;
});
if (!currentlyTyping) {
currentlyTyping = true;
room!
.setTyping(true, timeout: const Duration(seconds: 30).inMilliseconds);
}

@hoangdat
Copy link
Member

hoangdat commented Nov 7, 2025

please rebase

@hoangdat hoangdat merged commit 6dc1561 into main Nov 10, 2025
7 of 8 checks passed
@hoangdat hoangdat deleted the TW-2635/typing-timer branch November 10, 2025 23:35
@Crash--
Copy link

Crash-- commented Nov 12, 2025

We're adding complexity on top of complexity instead of fixing the root cause of the bug. This is not what we should do.

Did you took a look at our internal investigations? Why do we have multiple call at once to the /sync?since= route? When do we call sync without since? I'm pretty sure this is a race condition because of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants