Fix ci (#1)

lucemia · web-flow · commit 3fc3f7cdaeee · 2025-05-27T00:00:41.000+08:00
* add config

* add config

* fix

* fix

* fix

* add codecov
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,8 +29,26 @@ jobs:
     - name: Run linting
       run: npm run lint
 
-    - name: Run tests
-      run: npm test
+    - name: Run tests with coverage
+      run: npm run test:coverage
 
     - name: Build
-      run: npm run build 
+      run: npm run build
+
+    # Upload coverage report to Codecov
+    - name: Upload coverage to Codecov
+      uses: codecov/codecov-action@v5
+      with:
+        directory: ./coverage
+        flags: frontend,typescript,react
+        name: frontend-coverage
+        fail_ci_if_error: true
+        token: ${{ secrets.CODECOV_TOKEN }}
+        verbose: true
+
+    # Upload coverage reports as artifacts
+    - name: Upload coverage reports
+      uses: actions/upload-artifact@v4
+      with:
+        name: frontend-coverage-report
+        path: coverage 
diff --git a/codecov.yml b/codecov.yml
@@ -0,0 +1,25 @@
+coverage:
+  status:
+    project:
+      default:
+        target: 80%
+        threshold: 1%
+    patch:
+      default:
+        target: 80%
+        threshold: 1%
+
+comment:
+  layout: "reach, diff, flags, files"
+  behavior: default
+  require_changes: false
+
+ignore:
+  - "src/types/*.ts"
+  - "src/scripts/*.ts"
+  - "**/vite.config.ts"
+  - "**/vitest.config.ts"
+  - "**/*.test.ts"
+  - "**/*.test.tsx"
+  - "**/*.spec.ts"
+  - "**/*.spec.tsx" 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,11 +28,10 @@
   },
   "devDependencies": {
     "@eslint/js": "^9.22.0",
-    "@testing-library/jest-dom": "^6.6.3",
+    "@types/dagre": "^0.7.52",
     "@types/node": "^22.14.1",
     "@types/react": "^19.0.10",
     "@types/react-dom": "^19.0.4",
-    "@types/testing-library__jest-dom": "^6.0.0",
     "@vitejs/plugin-react": "^4.3.4",
     "@vitest/coverage-istanbul": "^3.1.2",
     "eslint": "^9.25.1",
diff --git a/src/App.tsx b/src/App.tsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import { CssBaseline, ThemeProvider, createTheme } from '@mui/material';
 import FFmpegFlowEditor from './components/FFmpegFlowEditor';
 
diff --git a/src/components/FilterNode.tsx b/src/components/FilterNode.tsx
@@ -11,7 +11,7 @@ interface ValidationError {
 
 function FilterNode({ data, id }: NodeProps<NodeData>) {
   const theme = useTheme();
-  const [parameters, setParameters] = useState<Record<string, string>>(data.parameters || {});
+  const [parameters, setParameters] = useState<Record<string, string | number | boolean>>(data.parameters || {});
   const [errors, setErrors] = useState<ValidationError>({});
   const [expanded, setExpanded] = useState<boolean>(false);
   const updateNodeInternals = useUpdateNodeInternals();
diff --git a/src/components/GlobalNode.tsx b/src/components/GlobalNode.tsx
@@ -19,7 +19,7 @@ const globalOptions = options.filter(
 
 function GlobalNode({ data, id }: NodeProps<NodeData>) {
   const theme = useTheme();
-  const [parameters, setParameters] = useState<Record<string, string>>(data.parameters || {});
+  const [parameters, setParameters] = useState<Record<string, string | boolean | number>>(data.parameters || {});
   const [expanded, setExpanded] = useState<boolean>(false);
 
   // Update local state when data changes
diff --git a/src/components/InputNode.tsx b/src/components/InputNode.tsx
@@ -14,7 +14,7 @@ const inputOptions = options.filter(
 function InputNode({ data, id }: NodeProps<NodeData>) {
   const theme = useTheme();
   const [filename, setFilename] = useState<string>(data.filename || '');
-  const [parameters, setParameters] = useState<Record<string, string>>(data.parameters || {});
+  const [parameters, setParameters] = useState<Record<string, string | number | boolean>>(data.parameters || {});
   const [expanded, setExpanded] = useState<boolean>(false);
 
   // Update local state when data changes
diff --git a/src/components/OutputNode.tsx b/src/components/OutputNode.tsx
@@ -14,7 +14,7 @@ const outputOptions = options.filter(
 function OutputNode({ data, id }: NodeProps<NodeData>) {
   const theme = useTheme();
   const [filename, setFilename] = useState<string>(data.filename || '');
-  const [parameters, setParameters] = useState<Record<string, string>>(data.parameters || {});
+  const [parameters, setParameters] = useState<Record<string, string | number | boolean>>(data.parameters || {});
   const [expanded, setExpanded] = useState<boolean>(false);
 
   // Update local state when data changes
diff --git a/src/utils/__tests__/nodeMapping.test.ts b/src/utils/__tests__/nodeMapping.test.ts
@@ -64,7 +64,7 @@ describe('Node Mapping', () => {
 
     // Deserialize
     const deserialized = loads(jsonString);
-    await nodeMappingManager._recursiveAddInternal(deserialized as Node | Stream);
+    await nodeMappingManager.recursiveAdd(deserialized as Stream);
     // check node mapping's snapshot
     expect(deserialized).toMatchSnapshot();
     expect(loads(nodeMappingManager.toJson())).toMatchSnapshot();
diff --git a/src/utils/serialize.ts b/src/utils/serialize.ts
@@ -1,5 +1,5 @@
-// Class registry for serialization
-type Constructor<T> = new (...args: unknown[]) => T;
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+type Constructor<T> = new (...args: any[]) => T;
 const classRegistry = new Map<string, Constructor<Serializable>>();
 
 // Base class for serializable objects
@@ -44,7 +44,7 @@ export function getRegisteredClassNames(): string[] {
 
 // Serialize an object to JSON string
 export function dumps(obj: unknown): string {
-  return JSON.stringify(obj, (key, value) => {
+  return JSON.stringify(obj, (_, value) => {
     if (value instanceof Map) {
       return {
         __type__: 'Map',
diff --git a/tsconfig.node.tsbuildinfo b/tsconfig.node.tsbuildinfo
diff --git a/tsconfig.tsbuildinfo b/tsconfig.tsbuildinfo
@@ -0,0 +1 @@
+{"root":["./src/app.tsx","./src/main.tsx","./src/vite-env.d.ts","./src/components/ffmpegfloweditor.tsx","./src/components/filternode.tsx","./src/components/globalnode.tsx","./src/components/inputnode.tsx","./src/components/outputnode.tsx","./src/components/previewpanel.tsx","./src/components/sidebar.tsx","./src/components/toolbar.tsx","./src/components/__tests__/isvalidconnection.test.tsx","./src/types/dag.ts","./src/types/edge.ts","./src/types/ffmpeg.ts","./src/types/filters.d.ts","./src/types/node.ts","./src/types/__tests__/dag.test.ts","./src/utils/connectionvalidation.ts","./src/utils/formulaevaluator.ts","./src/utils/generateffmpegcommand.ts","./src/utils/nodemapping.ts","./src/utils/pyodideutils.ts","./src/utils/serialize.ts","./src/utils/__tests__/formulaevaluator.test.ts","./src/utils/__tests__/generateffmpegcommand.test.ts","./src/utils/__tests__/nodemapping.test.ts","./src/utils/__tests__/serialize.test.ts","./src/utils/__tests__/testutils.ts"],"version":"5.7.3"}
diff --git a/vite.config.d.ts b/vite.config.d.ts
@@ -0,0 +1,2 @@
+declare const _default: import("vite").UserConfig;
+export default _default;
diff --git a/vite.config.js b/vite.config.js
@@ -0,0 +1,16 @@
+import { defineConfig } from 'vite';
+import react from '@vitejs/plugin-react';
+// https://vitejs.dev/config/
+export default defineConfig({
+    plugins: [react()],
+    resolve: {
+        alias: {
+            '@': '/src',
+        },
+    },
+    server: {
+        host: true,
+        port: 5173,
+        strictPort: true,
+    },
+});

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import React from 'react';`
`2`	`1`	`import { CssBaseline, ThemeProvider, createTheme } from '@mui/material';`
`3`	`2`	`import FFmpegFlowEditor from './components/FFmpegFlowEditor';`
`4`	`3`