Merge pull request #172 from livingdocsIO/fix-newline-behavior

Shift enter at end of text adds data tag to the added <br> tag

Author: mokimo

spec/cursor.spec.js

@@ -47,9 +47,15 @@ describe('Cursor', function () {
       expect(this.range.endOffset).toEqual(1)
     })
 
+    describe('isAtTextEnd()', () => {
+      it('returns true when at text end', () => {
+        expect(this.cursor.isAtEnd()).toBe(true)
+      })
+    })
+
     describe('isAtEnd()', () => {
       it('is true', () => {
-        expect(this.cursor.isAtEnd()).toBe(true)
+        expect(this.cursor.isAtTextEnd()).toBe(true)
       })
     })
 
@@ -66,6 +72,7 @@ describe('Cursor', function () {
         // move the cursor so we can check the restore method.
         this.cursor.moveAtBeginning()
         expect(this.cursor.isAtBeginning()).toBe(true)
+        expect(this.cursor.isAtTextEnd()).toBe(false)
 
         this.cursor.restore()
         expect(this.cursor.isAtEnd()).toBe(true)

spec/dispatcher.spec.js

@@ -195,5 +195,18 @@ describe('Dispatcher', () => {
         $elem.trigger(event)
       })
     })
+
+    describe('on newline', () => {
+      beforeEach(() => {
+        event = $.Event('keydown')
+        event.shiftKey = true
+        event.keyCode = 13
+      })
+
+      it('fires newline when shift + enter is pressed', (done) => {
+        on('newline', done)
+        $elem.trigger(event)
+      })
+    })
   })
 })

src/create-default-behavior.js

@@ -48,19 +48,13 @@ export default function createDefaultBehavior (editable) {
     },
 
     newline (element, cursor) {
-      cursor.insertBefore(document.createElement('br'))
 
-      if (cursor.isAtEnd()) {
-        log('at the end')
-
-        const noWidthSpace = document.createTextNode('\u200B')
-        cursor.insertAfter(noWidthSpace)
-
-        // var trailingBr = document.createElement('br')
-        // trailingBr.setAttribute('type', '-editablejs')
-        // cursor.insertAfter(trailingBr)
+      if (cursor.isAtTextEnd()) {
+        const trailingBr = document.createElement('br')
+        trailingBr.setAttribute('data-editable', 'remove')
+        cursor.insertBefore(trailingBr)
       } else {
-        log('not at the end')
+        cursor.insertBefore(document.createElement('br'))
       }
 
       cursor.setVisibleSelection()