fix(save-and-restore): use correct parent

gabrielhase · gabrielhase · commit d8207571aa6e · 2021-12-29T17:05:07.000+01:00
diff --git a/src/range-save-restore.js b/src/range-save-restore.js
@@ -19,13 +19,15 @@ function isChildOf (parent, possibleChild) {
 }
 
 function startContainerIsChild (range) {
-  const parent = range.endContainer.parentElement
+  const parent = range.commonAncestorContainer
+  if (parent.nodeType === 3) return false // if we are on the text node it can't be a parent
   const possibleChild = range.startContainer.parentElement
   return isChildOf(parent, possibleChild)
 }
 
 function endContainerIsChild (range) {
-  const parent = range.startContainer.parentElement
+  const parent = range.commonAncestorContainer
+  if (parent.nodeType === 3) return false // if we are on the text node it can't be a parent
   const possibleChild = range.endContainer.parentElement
   return isChildOf(parent, possibleChild)
 }

Original file line number	Diff line number	Diff line change
`@@ -19,13 +19,15 @@ function isChildOf (parent, possibleChild) {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`function startContainerIsChild (range) {`
`22`		`- const parent = range.endContainer.parentElement`
	`22`	`+ const parent = range.commonAncestorContainer`
	`23`	`+ if (parent.nodeType === 3) return false // if we are on the text node it can't be a parent`
`23`	`24`	`const possibleChild = range.startContainer.parentElement`
`24`	`25`	`return isChildOf(parent, possibleChild)`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`function endContainerIsChild (range) {`
`28`		`- const parent = range.startContainer.parentElement`
	`29`	`+ const parent = range.commonAncestorContainer`
	`30`	`+ if (parent.nodeType === 3) return false // if we are on the text node it can't be a parent`
`29`	`31`	`const possibleChild = range.endContainer.parentElement`
`30`	`32`	`return isChildOf(parent, possibleChild)`
`31`	`33`	`}`