chore: add tests and address PR comments

Author: Muhameti-centralsoft

spec/selection.spec.js

@@ -78,6 +78,31 @@ describe('Selection', function () {
     })
   })
 
+  describe('deleteExactSurroundingTags:', function () {
+    it('deletes the farest ancestor that exactly surrounds the selection', function () {
+      const content = createElement('<p>text <strong><em>italic</em></strong> text</p>')
+      const em = content.getElementsByTagName('em')[0]
+      const range = rangy.createRange()
+      range.setStart(em, 0)
+      range.setEnd(em, 1)
+      let selection = new Selection(content, range)
+      selection = selection.deleteExactSurroundingTags()
+      expect(selection.host.innerHTML).to.equal('text  text')
+    })
+  })
+
+  describe('deleteContainedTags:', function () {
+    it('deletes all the tags whose content is completely within the current selection: ', function () {
+      const content = createElement('<p>text <strong>bold</strong> text')
+      const range = rangy.createRange()
+      range.setStart(content, 1)
+      range.setEnd(content, 3)
+      let selection = new Selection(content, range)
+      selection = selection.deleteContainedTags()
+      expect(selection.host.innerHTML).to.equal('text  text')
+    })
+  })
+
   describe('with a range', function () {
 
     beforeEach(function () {

src/clipboard.js

@@ -30,8 +30,8 @@ export function paste (element, cursor, clipboardContent) {
   element.setAttribute(config.pastingAttribute, true)
 
   if (cursor.isSelection) {
-    cursor = cursor.deleteExactSurroundingMarkups()
-      .deleteContainedMarkupTags()
+    cursor = cursor.deleteExactSurroundingTags()
+      .deleteContainedTags()
       .deleteContent()
   }
 

src/selection.js

@@ -248,27 +248,23 @@ export default class Selection extends Cursor {
   // Delete the farest ancestor that is an exact selection
   //
   // @return Selection instance
-  deleteExactSurroundingMarkups () {
-    const ancestorMarkupTags = this.getAncestorTags(
-      (elem) => ['STRONG', 'EM'].includes(elem.nodeName)
-    ).reverse()
-    for (const ancestorMarkupTag of ancestorMarkupTags) {
-      if (this.isExactSelection(ancestorMarkupTag)) {
-        ancestorMarkupTag.remove()
+  deleteExactSurroundingTags () {
+    const ancestorTags = this.getAncestorTags().reverse()
+    for (const ancestorTag of ancestorTags) {
+      if (this.isExactSelection(ancestorTag)) {
+        ancestorTag.remove()
         break
       }
     }
     return new Selection(this.host, this.range)
   }
 
-  // Delete all the markups whose text is completely within the current selection.
+  // Delete all the tags whose text is completely within the current selection.
   //
   // @return Selection instance
-  deleteContainedMarkupTags () {
-    const containedMarkupTags = this.getContainedTags(
-      (elem) => ['STRONG', 'EM'].includes(elem.nodeName)
-    )
-    containedMarkupTags.forEach(containedMarkupTag => containedMarkupTag.remove())
+  deleteContainedTags () {
+    const containedTags = this.getContainedTags()
+    containedTags.forEach(containedTag => containedTag.remove())
     return new Selection(this.host, this.range)
   }