Skip to content

Commit 6288cf9

Browse files
committed
set STRUCTURED_TYPES_SUPPORTED=False in test suite
1 parent 45637a2 commit 6288cf9

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/workflows/build_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ jobs:
149149
# image_name=whummer/snowflake-tmp
150150
docker pull $image_name &
151151
pip install localstack
152-
IMAGE_NAME=$image_name DEBUG=1 localstack start -d
152+
IMAGE_NAME=$image_name DEBUG=1 DOCKER_FLAGS='-e SF_LOG=trace' localstack start -d
153153
localstack wait
154154
155155
# - name: Setup parameters file

test/integ/test_arrow_result.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,12 @@
172172
RUNNING_ON_GH = os.getenv("GITHUB_ACTIONS") == "true"
173173

174174
ICEBERG_SUPPORTED = CLOUD in ICEBERG_ENVIRONMENTS and RUNNING_ON_GH or CLOUD == "dev"
175-
STRUCTURED_TYPES_SUPPORTED = (
176-
CLOUD in STRUCTRED_TYPE_ENVIRONMENTS and RUNNING_ON_GH or CLOUD == "dev"
177-
)
175+
# STRUCTURED_TYPES_SUPPORTED = (
176+
# CLOUD in STRUCTRED_TYPE_ENVIRONMENTS and RUNNING_ON_GH or CLOUD == "dev"
177+
# )
178+
# Note whummer (2024-12-29): setting this to False, as otherwise invalid tests are being generated,
179+
# using, e.g., `CREATE TABLE(c1 ARRAY(FLOAT))` which is invalid in standard case (verified against real SF)
180+
STRUCTURED_TYPES_SUPPORTED = False
178181

179182
# Generate all valid test cases. By using pytest.param with an id you can
180183
# run a specific test case easier like so:

0 commit comments

Comments
 (0)