优化代码逻辑，修复潜在播放问题

Author: lyswhut

publish/changeLog.md

@@ -3,7 +3,7 @@
 
 - 修复备份文件导入指引无法识别v2配置的问题
 - 修复从搜索界面进入歌单详情后，若启用强迫症设置的清空功能会导致意外清空搜索框、搜索列表的问题
-- 就放桌面歌词在启用卡拉OK歌词后字体边缘可能被截断的问题
+- 修复桌面歌词在启用卡拉OK歌词后字体边缘可能被截断的问题（特别是纵向歌词某些字的边角被截断导致后面的阴影露出来或阴影不均匀的问题）
 - 修复桌面歌词启用歌词缩放后的阴影显示问题
 - 修复Linux armv7l系统（如树莓派）下无法启动的问题（与修复Linux arm64的方法一样采用内置预编译模块的方式修复）
 - 修复备份与恢复的列表导入列表信息设置逻辑问题与潜在导入问题

src/common/theme/utils.js

@@ -36,7 +36,7 @@ exports.createThemeColors = (rgbaColor, fontRgbaColor, isDark) => {
 const createFontColors = (rgbaColor, isDark) => {
   // rgb(238, 238, 238)
   // let prec = 'rgb(255, 255, 255)'
-  if (rgbaColor == null) rgbaColor = isDark ? 'rgb(229, 229, 229)' : 'rgb(33, 33, 33)'
+  rgbaColor ??= isDark ? 'rgb(229, 229, 229)' : 'rgb(33, 33, 33)'
   if (isDark) return createFontDarkColors(rgbaColor)
 
   let colors = {

src/common/utils/lyric-font-player/font-player.js

@@ -141,7 +141,7 @@ module.exports = class FontPlayer {
       // lineText += text
 
       if (this.shadowContent) {
-        if (!lrcShadowContent) lrcShadowContent = document.createElement('div')
+        lrcShadowContent ??= document.createElement('div')
         const shadowDom = document.createElement('span')
         shadowDom.textContent = text
         lrcShadowContent.appendChild(shadowDom)

src/common/utils/migrateSetting.ts

@@ -25,7 +25,7 @@ export default (setting: any): Partial<LX.AppSetting> => {
     // 迁移列表滚动位置设置 ~0.18.3
     if (setting.list?.scroll) {
       let scroll = setting.list.scroll
-      if (setting.list.isSaveScrollLocation) setting.list.isSaveScrollLocation = scroll.enable
+      setting.list.isSaveScrollLocation &&= scroll.enable
       delete setting.list.scroll
     }
 

src/common/utils/renderer.ts

@@ -244,7 +244,7 @@ export const scrollXRTo = (element: HTMLElement, to: number, duration = 300, fn
   */
 let dom_title = document.getElementsByTagName('title')[0]
 export const setTitle = (title: string | null) => {
-  if (!title) title = '洛雪音乐助手'
+  title ||= '洛雪音乐助手'
   dom_title.innerText = title
 }
 

src/main/modules/sync/server/utils.ts

@@ -44,7 +44,7 @@ export const createClientKeyInfo = (deviceName: string): LX.Sync.KeyInfo => {
     deviceName,
   }
   const store = getStore(STORE_NAME)
-  if (!keyInfos) keyInfos = store.get('keys') as KeyInfos || {}
+  keyInfos ??= store.get('keys') as KeyInfos || {}
   if (Object.keys(keyInfos).length > 101) throw new Error('max keys')
 
   keyInfos[keyInfo.clientId] = keyInfo

src/main/modules/userApi/main.ts

@@ -27,7 +27,7 @@ const winEvent = () => {
 
 export const createWindow = async(userApi: LX.UserApi.UserApiInfo) => {
   await closeWindow()
-  if (!dir) dir = global.isDev ? webpackUserApiPath : join(encodePath(__dirname), 'userApi')
+  dir ??= global.isDev ? webpackUserApiPath : join(encodePath(__dirname), 'userApi')
 
   if (!html) {
     html = await fs.promises.readFile(join(dir, 'renderer/user-api.html'), 'utf8')

src/main/modules/userApi/utils.ts

@@ -33,7 +33,7 @@ export const importApi = (script: string): LX.UserApi.UserApiInfo => {
     script,
     allowShowUpdateAlert: true,
   }
-  if (!userApis) userApis = []
+  userApis ??= []
   userApis.push(apiInfo)
   getStore(STORE_NAMES.USER_API).set('userApis', userApis)
   return apiInfo

src/main/modules/winMain/main.ts

@@ -20,7 +20,7 @@ const winEvent = () => {
       return
     }
 
-    if (global.lx.isTrafficLightClose) global.lx.isTrafficLightClose = false
+    global.lx.isTrafficLightClose &&= false
     event.preventDefault()
     browserWindow!.hide()
   })

src/main/utils/index.ts

@@ -113,7 +113,7 @@ export const updateSetting = (setting?: Partial<LX.AppSetting>, isInit: boolean
 
   let originSetting: LX.AppSetting
   if (isInit) {
-    if (setting) setting = migrateSetting(setting)
+    setting &&= migrateSetting(setting)
     originSetting = { ...defaultSetting }
   } else originSetting = global.lx.appSetting
 
@@ -196,7 +196,7 @@ export const openDevTools = (webContents: Electron.WebContents) => {
 
 let userThemes: LX.Theme[]
 export const getAllThemes = () => {
-  if (!userThemes) userThemes = getStore(STORE_NAMES.THEME).get('themes') as LX.Theme[] | null ?? []
+  userThemes ??= getStore(STORE_NAMES.THEME).get('themes') as (LX.Theme[] | null) ?? []
   return {
     themes,
     userThemes,