Commit 2d674d0
committed
ci: Fix test_popup failing on macos-13 due to lack of italics support
Up till macOS 13, the default terminal does not properly advertise it
supports italics, and Vim just silently replaces it with the "reverse"
effect. Revently, a test in test_popup (Test_popup_shadow_hiddenchar)
was added and the test dumps assume italics support. Add checks to skip
this test if we detect that italics is not supported to avoid failing
the screen dump tests.
Note that macos-13 is being sunset by GitHub Actions, but we still use a
self-hosted version of it to make legacy builds.
Note that due to MacVim silently passing all flaky tests currently, this
test wasn't breaking CI anyway, but it did slow it down due to test
retries, and we do want to go back to not silently passing flaky tests
in near future.1 parent 1ff7da6 commit 2d674d0
1 file changed
+9
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2396 | 2396 | | |
2397 | 2397 | | |
2398 | 2398 | | |
| 2399 | + | |
| 2400 | + | |
| 2401 | + | |
| 2402 | + | |
| 2403 | + | |
| 2404 | + | |
| 2405 | + | |
| 2406 | + | |
| 2407 | + | |
2399 | 2408 | | |
2400 | 2409 | | |
2401 | 2410 | | |
| |||
0 commit comments