Skip to content

Commit 2d674d0

Browse files
committed
ci: Fix test_popup failing on macos-13 due to lack of italics support
Up till macOS 13, the default terminal does not properly advertise it supports italics, and Vim just silently replaces it with the "reverse" effect. Revently, a test in test_popup (Test_popup_shadow_hiddenchar) was added and the test dumps assume italics support. Add checks to skip this test if we detect that italics is not supported to avoid failing the screen dump tests. Note that macos-13 is being sunset by GitHub Actions, but we still use a self-hosted version of it to make legacy builds. Note that due to MacVim silently passing all flaky tests currently, this test wasn't breaking CI anyway, but it did slow it down due to test retries, and we do want to go back to not silently passing flaky tests in near future.
1 parent 1ff7da6 commit 2d674d0

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/testdir/test_popup.vim

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2396,6 +2396,15 @@ endfunc
23962396
func Test_popup_shadow_hiddenchar()
23972397
CheckScreendump
23982398

2399+
if has('osx')
2400+
" On older macOS versions, the default Terminal app does not properly
2401+
" advertise italics support, which this test requires. When that happens,
2402+
" Vim just uses t_mr (reverse) as a substitute, which we detect here.
2403+
if &t_ZH == &t_mr
2404+
throw 'Skipped: italics not supported'
2405+
endif
2406+
endif
2407+
23992408
let lines =<< trim END
24002409
bold italic underline reverse normal
24012410
italic underline reverse normal bold

0 commit comments

Comments
 (0)