Skip to content

Commit b728d61

Browse files
chinmay3012Chinmay Mehrotrarenovate-botmahadzaryab1yurishkuro
authored
Fix: Remove tool installation from Go Tip workflow (jaegertracing#7716)
## Which problem is this PR solving? - Resolves jaegertracing#7664 ## Description of the changes - Removed the installation of stable Go and test dependencies (make install-test-tools) from the ci-unit-tests-go-tip.yml workflow. - Removed the "Lint" step, which was previously a placeholder and not performing actual linting in this workflow. - This ensures that tools (like linters) are not built using the potentially unstable Go Tip version, preventing unrelated build failures during Go Tip testing. The workflow now strictly focuses on compiling and running unit tests for Jaeger's core code against Go Tip. ## How was this change tested? - Tested by verifying that the workflow configuration is valid and correctly invokes make test-ci without the unnecessary prerequisite steps. - The change purely modifies the CI configuration to align with the requirement of not testing tools against Go Tip. --------- Signed-off-by: Chinmay Mehrotra <[email protected]> Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Chinmay Mehrotra <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Mahad Zaryab <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
1 parent 6b84213 commit b728d61

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

.github/workflows/ci-unit-tests-go-tip.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,6 @@ jobs:
2626

2727
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
2828

29-
- name: Set up stable Go for tools
30-
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
31-
with:
32-
go-version: 1.25.x
33-
34-
- name: Install test deps
35-
# even though the same target runs from test-ci, running it separately makes for cleaner log in GH workflow
36-
run: make install-test-tools
37-
3829
- name: Install Go Tip
3930
uses: ./.github/actions/setup-go-tip
4031
with:
@@ -48,5 +39,4 @@ jobs:
4839
- name: Run unit tests
4940
run: make test-ci
5041

51-
- name: Lint
52-
run: echo skip linting on Go tip
42+

0 commit comments

Comments
 (0)