bugfix in mathutils.Bits.as_list (#315)

* bugfix in mathutils.Bits.as_list

list(Bits(0, 2)) == [False, False] -- which is the correct behavior
Bits(0, 2).as_list() == [False] -- which was a bug

* DRY internal function and avoid blowing up length in tests

* fix tests

* bytes and hex both pad to 1 byte so combine test

* fix roundtripping tests

---------

Co-authored-by: Mahmoud Hashemi <[email protected]>

Author: kurtbrose

boltons/mathutils.py

@@ -215,7 +215,7 @@ def __hash__(self):
         return hash(self.val)
 
     def as_list(self):
-        return [c == '1' for c in '{0:b}'.format(self.val)]
+        return [c == '1' for c in self.as_bin()]
 
     def as_bin(self):
         return '{{0:0{0}b}}'.format(self.len).format(self.val)

tests/test_mathutils.py

@@ -95,15 +95,19 @@ def chk(a, b):
     chk(Bits('11') >> 1, Bits('1'))
     chk(Bits('1') << 1, Bits('10'))
     assert Bits('0') != Bits('00')
+    # test roundtrip as_/from_hex
+    chk(Bits.from_hex(Bits('10101010').as_hex()),
+        Bits('10101010'))
+    # test roundtrip as_/from_bytes
     chk(
-        Bits.from_bytes(
-            Bits.from_int(
-                Bits.from_hex(
-                    Bits.from_bin(
-                        Bits.from_list(
-                            Bits('101').as_list()
-                        ).as_bin()
-                    ).as_hex()
-                ).as_int()
-            ).as_bytes()
-    ), Bits('00000101'))
+        Bits.from_bytes(Bits('10101010').as_bytes()),
+        Bits('10101010'))
+    # pile of roundtripping
+    chk(Bits.from_int(
+            Bits.from_bin(
+                Bits.from_list(
+                    Bits('101').as_list()
+                ).as_bin()
+            ).as_int()
+        ),
+        Bits('101'))