Skip to content

Commit 62babc6

Browse files
authored
Merge pull request #14 from anthonygore/master
Correctly removing image observer entry after image has loaded
2 parents f1fc170 + 76e42ba commit 62babc6

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

dist/yall-1.1.1.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
},
2424
"homepage": "https://github.com/malchata/yall.js#readme",
2525
"devDependencies": {
26+
"npx": "^9.7.1",
2627
"uglify-js": "^3.0.27"
2728
},
2829
"dependencies": {}

src/yall.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
replaceAttr(img, "data-src", "src");
4646
replaceAttr(img, dss, "srcset");
4747
img.classList.remove("lazy");
48-
elements.splice(elements.indexOf(img), 1);
4948
},
5049
// A multiple event binding handler.
5150
multiBind = function(obj, handlers, fn, remove){
@@ -88,11 +87,10 @@
8887
var imageObserver = new window[io](function(entries, observer){
8988
entries[fe](function(entry){
9089
if(entry.isIntersecting){
91-
loadImage(entry.target);
92-
93-
if(!elements[ln]){
94-
observer.disconnect();
95-
}
90+
if(entry.isIntersecting){
91+
loadImage(entry.target);
92+
imageObserver.unobserve(entry.target);
93+
}
9694
}
9795
});
9896
});

0 commit comments

Comments
 (0)