Throw exception on System.loadLibrary fail (#3916)

Author: adrian-cojocaru

platform/android/MapLibreAndroid/src/main/java/org/maplibre/android/LibraryLoader.java

@@ -20,6 +20,7 @@ public abstract class LibraryLoader {
   private static volatile LibraryLoader loader = DEFAULT;
 
   private static boolean loaded;
+  private static boolean handleLoadError = false;
 
   /**
    * Set the library loader that loads the shared library.
@@ -30,10 +31,17 @@ public static void setLibraryLoader(LibraryLoader libraryLoader) {
     loader = libraryLoader;
   }
 
+  /**
+   * Catch UnsatisfiedLinkErrors on load
+   */
+  public static void enableErrorHandling(boolean value) {
+    handleLoadError = value;
+  }
+
   /**
    * Loads "libmaplibre.so" native shared library.
    * <p>
-   * Catches UnsatisfiedLinkErrors and prints a warning to logcat.
+   * Catches UnsatisfiedLinkErrors (if enabled) and prints a warning to logcat.
    * </p>
    */
   public static synchronized void load() {
@@ -47,6 +55,10 @@ public static synchronized void load() {
       String message = "Failed to load native shared library.";
       Logger.e(TAG, message, error);
       MapStrictMode.strictModeViolation(message, error);
+
+      if (!handleLoadError) {
+        throw error;
+      }
     }
   }
 

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/BaseTest.kt

@@ -0,0 +1,13 @@
+package org.maplibre.android
+
+import org.junit.BeforeClass
+
+open class BaseTest {
+    companion object {
+        @JvmStatic
+        @BeforeClass
+        fun setup() {
+            LibraryLoader.enableErrorHandling(true)
+        }
+    }
+}

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/MapLibreTest.kt

@@ -20,7 +20,7 @@ import org.mockito.ArgumentMatchers
 import org.mockito.Mockito
 import java.io.File
 
-class MapLibreTest {
+class MapLibreTest : BaseTest() {
     private var context: Context? = null
     private var appContext: Context? = null
 

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/annotations/AnnotationTest.kt

@@ -4,10 +4,11 @@ import org.maplibre.android.maps.MapLibreMap
 import org.junit.Assert
 import org.junit.Before
 import org.junit.Test
+import org.maplibre.android.BaseTest
 import org.mockito.InjectMocks
 import org.mockito.Mockito
 
-class AnnotationTest {
+class AnnotationTest : BaseTest() {
     @InjectMocks
     private val maplibreMap = Mockito.mock(MapLibreMap::class.java)
     private var annotation: Annotation? = null

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/annotations/IconTest.kt

@@ -4,11 +4,12 @@ import android.graphics.Bitmap
 import org.junit.Assert
 import org.junit.Before
 import org.junit.Test
+import org.maplibre.android.BaseTest
 import org.mockito.Mock
 import org.mockito.Mockito
 import org.mockito.MockitoAnnotations
 
-class IconTest {
+class IconTest : BaseTest() {
     @Mock
     var bitmap: Bitmap? = null
 

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/annotations/InfoWindowTest.kt

@@ -7,10 +7,11 @@ import org.maplibre.android.maps.MapLibreMap
 import org.maplibre.android.maps.Projection
 import org.junit.Assert
 import org.junit.Test
+import org.maplibre.android.BaseTest
 import org.mockito.InjectMocks
 import org.mockito.Mockito
 
-class InfoWindowTest {
+class InfoWindowTest : BaseTest() {
     @InjectMocks
     var mMapView = Mockito.mock(MapView::class.java)
 

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/annotations/MarkerTest.kt

@@ -6,9 +6,10 @@ import org.maplibre.android.geometry.LatLng
 import org.maplibre.android.utils.MockParcel
 import org.junit.Assert
 import org.junit.Test
+import org.maplibre.android.BaseTest
 import org.mockito.Mockito
 
-class MarkerTest {
+class MarkerTest : BaseTest() {
     @Test
     fun testSanity() {
         val markerOptions = MarkerOptions()

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/annotations/PolygonTest.kt

@@ -3,8 +3,9 @@ package org.maplibre.android.annotations
 import org.maplibre.android.geometry.LatLng
 import org.junit.Assert
 import org.junit.Test
+import org.maplibre.android.BaseTest
 
-class PolygonTest {
+class PolygonTest : BaseTest() {
     @Test
     fun testSanity() {
         val polygonOptions = PolygonOptions()

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/annotations/PolylineTest.kt

@@ -3,8 +3,9 @@ package org.maplibre.android.annotations
 import org.maplibre.android.geometry.LatLng
 import org.junit.Assert
 import org.junit.Test
+import org.maplibre.android.BaseTest
 
-class PolylineTest {
+class PolylineTest : BaseTest() {
     @Test
     fun testSanity() {
         val polylineOptions = PolylineOptions()

platform/android/MapLibreAndroid/src/test/java/org/maplibre/android/attribution/AttributionParseTest.kt

@@ -3,11 +3,12 @@ package org.maplibre.android.attribution
 import org.junit.Assert
 import org.junit.Test
 import org.junit.runner.RunWith
+import org.maplibre.android.BaseTest
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.RuntimeEnvironment
 
 @RunWith(RobolectricTestRunner::class)
-class AttributionParseTest {
+class AttributionParseTest : BaseTest() {
     @Test
     @Throws(Exception::class)
     fun testParseAttributionStringSatellite() {