Skip to content

Fix build-reports.csv only containing a single line #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix build-reports.csv only containing a single line #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6188045
Avoid doing lazy IO on build-reports.csv
keysmashes Oct 23, 2025
2281249
Avoid needlessly using a separate file for build-reports.csv locking
keysmashes Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/NOM/Update/Monad/CacheBuildReports.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import NOM.Builds (Host (..))
import Relude
import System.Directory (XdgDirectory (XdgCache), createDirectoryIfMissing, getXdgDirectory)
import System.FileLock (SharedExclusive (Exclusive), withFileLock)
import System.FilePath ((<.>), (</>))
import System.FilePath ((</>))

-- Exposed functions

Expand Down Expand Up @@ -53,13 +53,13 @@ tryUpdateBuildReports updateFunc = do
dir <- buildReportsDir
catchIO (createDirectoryIfMissing True dir) (const pass)
withFileLock
(dir </> buildReportsFilename <.> "lock")
(dir </> buildReportsFilename)
Exclusive
(const $ updateBuildReportsUnlocked updateFunc dir)

updateBuildReportsUnlocked :: (BuildReportMap -> BuildReportMap) -> FilePath -> IO BuildReportMap
updateBuildReportsUnlocked updateFunc dir = do
reports <- updateFunc <$> loadBuildReports dir
!reports <- updateFunc <$> loadBuildReports dir
reports <$ saveBuildReports dir reports

buildReportsDir :: IO FilePath
Expand Down