Improve error handling of tasks that are not waited anymore due to a timeout (fix #4211, fix #4172)

Author: marticliment

src/UniGetUI.Core.Tools/Tools.cs

@@ -752,5 +752,20 @@ public static string GetCurrentLocale()
         private static readonly HashSet<char> _illegalPathChars = Path.GetInvalidFileNameChars().ToHashSet();
         public static string MakeValidFileName(string name)
             => string.Concat(name.Where(x => !_illegalPathChars.Contains(x)));
+
+
+        // Safely wait for a task that may throw an exception we don't care about
+        public static async void FinalizeDangerousTask(Task t)
+        {
+            try
+            {
+                await t.ConfigureAwait(false);   
+            }
+            catch (Exception ex)
+            {
+                Logger.Error($"Task {t} crashed with exception:");
+                Logger.Error(ex);
+            }
+        }
     }
 }

src/UniGetUI.PackageEngine.PackageManagerClasses/Manager/Helpers/BaseSourceHelper.cs

@@ -1,6 +1,7 @@
 using UniGetUI.Core.Classes;
 using UniGetUI.Core.Logging;
 using UniGetUI.Core.SettingsEngine;
+using UniGetUI.Core.Tools;
 using UniGetUI.PackageEngine.Enums;
 using UniGetUI.PackageEngine.Interfaces;
 using UniGetUI.PackageEngine.Interfaces.ManagerProviders;
@@ -64,9 +65,13 @@ public virtual IReadOnlyList<IManagerSource> _getSources()
                 if (!task.Wait(TimeSpan.FromSeconds(PackageListingTaskTimeout)))
                 {
                     if (!Settings.Get(Settings.K.DisableTimeoutOnPackageListingTasks))
+                    {
+                        CoreTools.FinalizeDangerousTask(task);
                         throw new TimeoutException($"Task _getInstalledPackages for manager {Manager.Name} did not finish after " +
                                                    $"{PackageListingTaskTimeout} seconds, aborting.  You may disable " +
                                                    $"timeouts from UniGetUI Advanced Settings");
+                    }
+
                     task.Wait();
                 }
 

src/UniGetUI.PackageEngine.PackageManagerClasses/Manager/PackageManager.cs

@@ -234,9 +234,13 @@ private IReadOnlyList<IPackage> _findPackages(string query, bool SecondAttempt)
                 if (!task.Wait(TimeSpan.FromSeconds(PackageListingTaskTimeout)))
                 {
                     if (!Settings.Get(Settings.K.DisableTimeoutOnPackageListingTasks))
+                    {
+                        CoreTools.FinalizeDangerousTask(task);
                         throw new TimeoutException($"Task _getInstalledPackages for manager {Name} did not finish after " +
                                                    $"{PackageListingTaskTimeout} seconds, aborting.  You may disable " +
                                                    $"timeouts from UniGetUI Advanced Settings");
+                    }
+
                     task.Wait();
                 }
 
@@ -273,15 +277,19 @@ private IReadOnlyList<IPackage> _getAvailableUpdates(bool SecondAttempt)
             if (!IsReady()) { Logger.Warn($"Manager {Name} is disabled but yet GetAvailableUpdates was called"); return []; }
             try
             {
-                Task.Run(RefreshPackageIndexes).Wait(TimeSpan.FromSeconds(60));
+                Task.Run(RefreshPackageIndexes).Wait(TimeSpan.FromSeconds(PackageListingTaskTimeout));
 
                 var task = Task.Run(GetAvailableUpdates_UnSafe);
                 if (!task.Wait(TimeSpan.FromSeconds(PackageListingTaskTimeout)))
                 {
                     if (!Settings.Get(Settings.K.DisableTimeoutOnPackageListingTasks))
+                    {
+                        CoreTools.FinalizeDangerousTask(task);
                         throw new TimeoutException($"Task _getInstalledPackages for manager {Name} did not finish after " +
                                                    $"{PackageListingTaskTimeout} seconds, aborting.  You may disable " +
                                                    $"timeouts from UniGetUI Advanced Settings");
+                    }
+
                     task.Wait();
                 }
 
@@ -322,9 +330,13 @@ private IReadOnlyList<IPackage> _getInstalledPackages(bool SecondAttempt)
                 if (!task.Wait(TimeSpan.FromSeconds(PackageListingTaskTimeout)))
                 {
                     if (!Settings.Get(Settings.K.DisableTimeoutOnPackageListingTasks))
+                    {
+                        CoreTools.FinalizeDangerousTask(task);
                         throw new TimeoutException($"Task _getInstalledPackages for manager {Name} did not finish after " +
                                                    $"{PackageListingTaskTimeout} seconds, aborting.  You may disable " +
                                                    $"timeouts from UniGetUI Advanced Settings");
+                    }
+
                     task.Wait();
                 }