- PR feedback

Author: gkinsman

src/Logging.XUnit/XUnitLogger.cs

@@ -276,14 +276,18 @@ private static void GetScopeInformation(StringBuilder builder)
             }
 
             var depth = 0;
-            string DepthPadding(int depth) => new string(' ', depth * 2);
+            static string DepthPadding(int depth) => new string(' ', depth * 2);
 
-            while (stack.Any())
+            while (stack.Count > 0)
             {
                 var elem = stack.Pop();
                 foreach (var property in StringifyScope(elem))
                 {
-                    builder.AppendLine($"{MessagePadding}{DepthPadding(depth)}=> {property}");
+                    builder.Append(MessagePadding)
+                           .Append(DepthPadding(depth))
+                           .Append("=> ")
+                           .Append(property)
+                           .AppendLine();
                 }
 
                 depth++;
@@ -301,7 +305,7 @@ private static IEnumerable<string> StringifyScope(XUnitLogScope scope)
             {
                 foreach (var pair in pairs)
                 {
-                    yield return $"{pair.Key}: {pair.Value}";
+                    yield return pair.Key + ": " + pair.Value;
                 }
             }
             else if (scope.State is IEnumerable<string> entries)

tests/Logging.XUnit.Tests/XUnitLoggerTests.cs

@@ -501,7 +501,9 @@ public static void XUnitLogger_Log_Logs_Message_If_Scopes_Included_And_There_Is_
 
             string expected = string.Join(
                 Environment.NewLine,
-                new[] { "[2018-08-19 16:12:16Z] info: MyName[0]", "      => ScopeKey: ScopeValue", "      Message|False|False" });
+                "[2018-08-19 16:12:16Z] info: MyName[0]",
+                "      => ScopeKey: ScopeValue",
+                "      Message|False|False");
 
             // Act
             using (logger.BeginScope(new[]