Skip to content

Commit 0d504e0

Browse files
committed
Merge pull request #22 from masaruh/2.1.0_upgrade
Upgrade to 2.1.0
2 parents 476e08e + bc40ab7 commit 0d504e0

File tree

3 files changed

+24
-20
lines changed

3 files changed

+24
-20
lines changed

pom.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,16 @@
66

77
<groupId>org.elasticsearch</groupId>
88
<artifactId>elasticsearch-japanese-suggester</artifactId>
9-
<version>0.20.2</version>
9+
<version>0.21.0</version>
1010

1111

1212
<packaging>jar</packaging>
1313

1414
<properties>
15-
<elasticsearch.version>2.0.2</elasticsearch.version>
16-
<lucene.version>5.2.1</lucene.version>
15+
<elasticsearch.version>2.1.0</elasticsearch.version>
16+
<lucene.version>5.3.1</lucene.version>
17+
<jackson.version>2.6.2</jackson.version>
18+
<testframework.version>2.1.16</testframework.version>
1719
</properties>
1820

1921
<dependencies>
@@ -41,7 +43,7 @@
4143
<dependency>
4244
<groupId>com.fasterxml.jackson.core</groupId>
4345
<artifactId>jackson-databind</artifactId>
44-
<version>2.5.3</version>
46+
<version>${jackson.version}</version>
4547
<scope>compile</scope>
4648
</dependency>
4749

@@ -70,7 +72,7 @@
7072
<dependency>
7173
<groupId>com.carrotsearch.randomizedtesting</groupId>
7274
<artifactId>randomizedtesting-runner</artifactId>
73-
<version>2.1.10</version>
75+
<version>${testframework.version}</version>
7476
<scope>test</scope>
7577
</dependency>
7678

src/main/java/org/elasticsearch/analysis/KuromojiSuggestTokenizerFactory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@
77
import org.elasticsearch.env.Environment;
88
import org.elasticsearch.index.Index;
99
import org.elasticsearch.index.analysis.AbstractTokenizerFactory;
10-
import org.elasticsearch.index.settings.IndexSettings;
10+
import org.elasticsearch.index.settings.IndexSettingsService;
1111

1212
public class KuromojiSuggestTokenizerFactory extends AbstractTokenizerFactory {
1313
private final boolean expand;
1414
private final int maxExpansions;
1515
private final boolean edgeNGram;
1616

1717
@Inject
18-
public KuromojiSuggestTokenizerFactory(Index index, @IndexSettings Settings indexSettings, Environment env, @Assisted String name, @Assisted Settings settings) {
19-
super(index, indexSettings, name, settings);
18+
public KuromojiSuggestTokenizerFactory(Index index, IndexSettingsService indexSettingsService, Environment env, @Assisted String name, @Assisted Settings settings) {
19+
super(index, indexSettingsService.getSettings(), name, settings);
2020

2121
this.expand = settings.getAsBoolean("expand", false);
2222
this.maxExpansions = settings.getAsInt("max_expansions", 512);

src/test/java/org/elasticsearch/search/suggest/completion/JapaneseCompletionSuggesterTest.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,28 @@
55
import com.google.common.collect.Lists;
66
import org.apache.lucene.util.LuceneTestCase;
77
import org.elasticsearch.action.suggest.SuggestResponse;
8-
import org.elasticsearch.common.settings.Settings;
98
import org.elasticsearch.plugin.JapaneseSuggesterPlugin;
9+
import org.elasticsearch.plugins.Plugin;
1010
import org.elasticsearch.search.suggest.Suggest;
1111
import org.elasticsearch.test.ESIntegTestCase;
1212
import org.junit.Assert;
1313
import org.junit.Test;
1414

1515
import java.io.IOException;
16+
import java.util.Collection;
1617
import java.util.List;
1718

1819
import static org.elasticsearch.common.xcontent.XContentFactory.jsonBuilder;
1920
import static org.hamcrest.Matchers.equalTo;
2021
import static org.hamcrest.Matchers.is;
2122

2223
@LuceneTestCase.SuppressCodecs("*")
24+
@ESIntegTestCase.ClusterScope(scope = ESIntegTestCase.Scope.SUITE)
2325
public class JapaneseCompletionSuggesterTest extends ESIntegTestCase {
2426

2527
@Override
26-
protected Settings nodeSettings(int nodeOrdinal) {
27-
return Settings.settingsBuilder().put(super.nodeSettings(nodeOrdinal)).put("plugin.types", JapaneseSuggesterPlugin.class.getName()).build();
28+
protected Collection<Class<? extends Plugin>> nodePlugins() {
29+
return pluginList(JapaneseSuggesterPlugin.class);
2830
}
2931

3032
@Override
@@ -47,14 +49,14 @@ public void testJapaneseCompletion() throws Exception {
4749

4850
feedDocument(index, type, field, "東京");
4951
feedDocument(index, type, field, "豆腐");
50-
optimize();
51-
52-
// assertSuggestResult(index, field, "とう", "東京", "豆腐");
53-
// assertSuggestResult(index, field, "tou", "東京", "豆腐");
54-
// assertSuggestResult(index, field, "とうf", "豆腐");
55-
// assertSuggestResult(index, field, "とうk", "東京");
56-
// assertSuggestResult(index, field, "東", "東京");
57-
// assertSuggestResult(index, field, "豆", "豆腐");
52+
forceMerge();
53+
54+
assertSuggestResult(index, field, "とう", "東京", "豆腐");
55+
assertSuggestResult(index, field, "tou", "東京", "豆腐");
56+
assertSuggestResult(index, field, "とうf", "豆腐");
57+
assertSuggestResult(index, field, "とうk", "東京");
58+
assertSuggestResult(index, field, "東", "東京");
59+
assertSuggestResult(index, field, "豆", "豆腐");
5860
assertSuggestResult(index, field, "党", null);
5961
}
6062

@@ -72,7 +74,7 @@ public void testPrefixFiltering() throws IOException {
7274
for (; i < 10; i++) {
7375
feedDocument(index, type, field, "省エネ" + i, i + 1);
7476
}
75-
optimize();
77+
forceMerge();
7678
assertSuggestResult(index, field, "小", 1, "小学校");
7779

7880
// Add another document.

0 commit comments

Comments
 (0)