fix: OZ ZKsync OS non interop v30, L-06 #1874
Conversation
0xValera
requested review from
StanislavBreadless and
vladbochok
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| import {IExecutor} from "contracts/state-transition/chain-interfaces/IExecutor.sol"; | ||
| import {SystemLogKey} from "../../../../system-contracts/contracts/Constants.sol"; |
There was a problem hiding this comment.
Importing SystemLogKey from Constants.sol now pulls the enum that no longer defines USED_L2_DA_VALIDATOR_ADDRESS_KEY, but this helper still relies on that name later in the file (e.g., lines 108/129/132). With the import changed here, the file will not compile because the referenced enum member is undefined. Update the downstream uses to USED_L2_DA_VALIDATION_COMMITMENT_SCHEME_KEY or adjust the helper to the new enum.
Useful? React with 👍 / 👎.
| constructL2Log( | ||
| true, | ||
| L2_TO_L1_MESSENGER, | ||
| SYSTEM_LOG_KEYS.USED_L2_DA_VALIDATOR_ADDRESS_KEY, | ||
| SYSTEM_LOG_KEYS.USED_L2_DA_VALIDATION_COMMITMENT_SCHEME_KEY, | ||
| process.env.CONTRACTS_L2_DA_VALIDATOR_ADDR | ||
| ), |
There was a problem hiding this comment.
The log builders still populate USED_L2_DA_VALIDATION_COMMITMENT_SCHEME_KEY with CONTRACTS_L2_DA_VALIDATOR_ADDR, but L1Messenger now emits this log as the commitment scheme enum (uint256(_l2DACommitmentScheme)) and Executor compares uint256(logValue) against s.l2DACommitmentScheme when processing it. Feeding an address here will cause any logs produced by this helper to fail that validation path. This log should carry the commitment scheme value instead of the validator address.
Useful? React with 👍 / 👎.
1 participant
What ❔
Why ❔
Checklist