fix: OZ ZKsync OS non interop v30, L-10 #1878
Conversation
0xValera
requested review from
StanislavBreadless and
vladbochok
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /// @param _plonkVerifier The address of the PLONK verifier contract. | ||
| /// @param _initialOwner The address of the initial owner of this contract. | ||
| constructor(IVerifierV2 _fflonkVerifier, IVerifier _plonkVerifier, address _initialOwner) { | ||
| fflonkVerifiers[0] = _fflonkVerifier; | ||
| /// @dev FFLONK is not supported for ZKsync OS as it has been deprecated. | ||
| constructor(IVerifier _plonkVerifier, address _initialOwner) { | ||
| plonkVerifiers[0] = _plonkVerifier; | ||
| _transferOwnership(_initialOwner); |
There was a problem hiding this comment.
The constructor at this location now accepts only a PLONK verifier and the owner, but the rest of the repo still constructs ZKsyncOSDualVerifier with the old three-argument signature (e.g., ZKsyncOSTestnetVerifier calls ZKsyncOSDualVerifier(_fflonkVerifier, _plonkVerifier, _initialOwner) at l1-contracts/contracts/state-transition/verifiers/ZKsyncOSTestnetVerifier.sol:15-20 and GatewayCTMDeployer instantiates it with fflonk + plonk addresses at l1-contracts/contracts/state-transition/chain-deps/GatewayCTMDeployer.sol:328-347). With this change the project no longer compiles because those call sites supply too many arguments.
Useful? React with 👍 / 👎.
| /// @notice Adds a new PLONK verifier for the specified version. | ||
| /// @param version The version number for the verifier. | ||
| /// @param _plonkVerifier The address of the PLONK verifier contract. | ||
| /// @dev Only PLONK verifiers are supported. FFLONK has been deprecated for ZKsync OS. | ||
| function addVerifier(uint32 version, IVerifier _plonkVerifier) external onlyOwner { | ||
| plonkVerifiers[version] = _plonkVerifier; |
There was a problem hiding this comment.
The addVerifier function now only accepts a PLONK verifier, but the deployment script still calls addVerifier(DEFAULT_ZKSYNC_OS_VERIFIER_VERSION, IVerifierV2(...), IVerifier(...)) (see l1-contracts/deploy-scripts/DeployCTM.s.sol:223-227). This mismatch causes a compile-time error and prevents the deployment script from building.
Useful? React with 👍 / 👎.
1 participant
What ❔
Why ❔
Checklist