Skip to content

Do not show the "and/or" dropdown for the first filter of a segment #15580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: 7.x
Choose a base branch
from
Open

Do not show the "and/or" dropdown for the first filter of a segment #15580

wants to merge 5 commits into from
+2 −2

Conversation

@kniziol
Copy link
Contributor

@kniziol kniziol commented Oct 19, 2025 •
edited
Loading

Summary

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? n/a
Related user documentation PR URL n/a
Related developer documentation PR URL n/a
Issue(s) addressed Fixes #15230

Description

Before After
the "and/or" dropdown is visible always, for each filter the "and/or" dropdown is visible for non-first filters only

📋 Steps to test this PR:

  1. Create a new segment
  2. Add filter
  3. See selector

Please see the attached video:

Screen.Recording.2025-10-19.at.21.44.04.mov

@kniziol kniziol mentioned this pull request Oct 19, 2025
Open
1 task
@escopecz escopecz added bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging segments Anything related to segments labels Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.28%. Comparing base (2e17cb6) to head (c6af535).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #15580      +/-   ##
============================================
- Coverage     68.28%   68.28%   -0.01%     
  Complexity    36578    36578              
============================================
  Files          2378     2378              
  Lines        137734   137734              
============================================
- Hits          94052    94051       -1     
- Misses        43682    43683       +1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LeonOltmanns
LeonOltmanns approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@LeonOltmanns LeonOltmanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change - thanks for the PR! :)

@LeonOltmanns LeonOltmanns added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Oct 24, 2025
@LeonOltmanns LeonOltmanns moved this to ⏳︎ Needs 1 more test in Open Source Fridays Oct 24, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jos0405
jos0405 approved these changes Nov 1, 2025
View reviewed changes
Copy link
Contributor

@jos0405 jos0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as described.

@jos0405 jos0405 added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jos0405 jos0405 jos0405 approved these changes

@andersonjeccel andersonjeccel Awaiting requested review from andersonjeccel

+1 more reviewer

@LeonOltmanns LeonOltmanns LeonOltmanns approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging segments Anything related to segments user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.

Projects

Open Source Fridays
Status: ⏳︎ Needs 1 more test

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Single segment filter show not editable "and/or" selector

4 participants

@kniziol @jos0405 @LeonOltmanns @escopecz