GPIO test bugfixes, implement open drain and pullup/pulldown tests

Author: multiplemonomials

CI-Shield-Tests/DigitalIOTest.cpp

@@ -66,6 +66,56 @@ void DigitalIO_StackAllocated_Test()
     TEST_ASSERT_MESSAGE(0 == din,"Expected value to be 0, read value was not zero");
 }
 
+// Test of pull up and pull down mode
+template <PinName dout_pin, PinName din_pin>
+void DigitalIO_PullUpPullDown_Test()
+{
+    DigitalIn dout(dout_pin);
+    DigitalIn din(din_pin, PullNone); // Make sure no pullup/pulldown is active on this pin as some targets have this by default.
+
+    // test 0
+    dout.mode(PullDown);
+    wait_us(GPIO_PROPAGATION_TIME);
+    TEST_ASSERT_MESSAGE(0 == din.read(),"Expected value to be 0, read value was not zero");
+
+    // test 1
+    dout.mode(PullUp);
+    wait_us(GPIO_PROPAGATION_TIME);
+    TEST_ASSERT_MESSAGE(1 == din.read(),"Expected value to be 1, read value was not one");
+}
+
+// Test that open-drain mode works as expected
+template <PinName dout_pin, PinName din_pin>
+void DigitalIO_OpenDrain_Test()
+{
+    DigitalInOut openDrain(dout_pin, PIN_OUTPUT, OpenDrain, 1);
+    DigitalInOut connectedPin(din_pin, PIN_INPUT, PullUp, 0);
+
+    // With the open drain pin not outputting anything, we should see both pins reading high
+    wait_us(GPIO_PROPAGATION_TIME);
+    TEST_ASSERT_MESSAGE(1 == openDrain.read(), "openDrain was low!");
+    TEST_ASSERT_MESSAGE(1 == connectedPin.read(), "connectedPin was low!");
+
+    // Outputting a low on the open drain pin should bring both pins low
+    openDrain = 0;
+    wait_us(GPIO_PROPAGATION_TIME);
+    TEST_ASSERT_MESSAGE(0 == openDrain.read(), "openDrain was high!");
+    TEST_ASSERT_MESSAGE(0 == connectedPin.read(), "connectedPin was high!");
+
+    // Outputting a high should cause both pins to go high again
+    openDrain = 1;
+    wait_us(GPIO_PROPAGATION_TIME);
+    TEST_ASSERT_MESSAGE(1 == openDrain.read(), "openDrain was low!");
+    TEST_ASSERT_MESSAGE(1 == connectedPin.read(), "connectedPin was low!");
+
+    // If we output a logic low with the other pin, this should be detectable with the open drain pin
+    connectedPin.output();
+    connectedPin.write(0);
+    wait_us(GPIO_PROPAGATION_TIME);
+    TEST_ASSERT_MESSAGE(0 == openDrain.read(), "openDrain was high!");
+    TEST_ASSERT_MESSAGE(0 == connectedPin.read(), "connectedPin was high!");
+}
+
 utest::v1::status_t test_setup(const size_t number_of_cases) {
     // Setup Greentea using a reasonable timeout in seconds
     GREENTEA_SETUP(30, "default_auto");
@@ -80,10 +130,12 @@ utest::v1::status_t test_setup(const size_t number_of_cases) {
 
 // Test cases
 Case cases[] = {
-    Case("Digital I/O GPOUT_0 -> GPIN_0", DigitalIO_Global_Test<GPOUT_0, GPIN_0, 0>),
-    Case("Digital I/O GPOUT_1 -> GPIN_1", DigitalIO_Global_Test<GPOUT_1, GPIN_1, 1>),
-    Case("Digital I/O GPIN_2 -> GPOUT_2", DigitalIO_StackAllocated_Test<PIN_GPOUT_2, PIN_GPIN_2>),
-    Case("Digital I/O GPOUT_2 -> GPIN_2", DigitalIO_StackAllocated_Test<PIN_GPIN_2, PIN_GPOUT_2>),
+    Case("Digital I/O GPOUT_0 -> GPIN_0 (Global)", DigitalIO_Global_Test<GPOUT_0, GPIN_0, 0>),
+    Case("Digital I/O GPOUT_1 -> GPIN_1 (Global)", DigitalIO_Global_Test<GPOUT_1, GPIN_1, 1>),
+    Case("Digital I/O GPIN_2 -> GPOUT_2 (Stack Allocated)", DigitalIO_StackAllocated_Test<PIN_GPOUT_2, PIN_GPIN_2>),
+    Case("Digital I/O GPOUT_2 -> GPIN_2 (Stack Allocated)", DigitalIO_StackAllocated_Test<PIN_GPIN_2, PIN_GPOUT_2>),
+    Case("Digital I/O Pull-Up and Pull-Down Mode", DigitalIO_PullUpPullDown_Test<PIN_GPIN_2, PIN_GPOUT_2>),
+    Case("Digital I/O Open Drain Mode", DigitalIO_OpenDrain_Test<PIN_GPIN_2, PIN_GPOUT_2>)
 };
 
 Specification specification(test_setup, cases, greentea_continue_handlers);

CI-Shield-Tests/InterruptInTest.cpp

@@ -44,6 +44,7 @@ void InterruptInTest()
 	callbackCounts = 0;
 	InterruptIn intin(int_pin);
 	DigitalOut dout(dout_pin, 0);
+	wait_us(GPIO_PROPAGATION_TIME);
 
 	// Test Rising Edge InterruptIn
 	DEBUG_PRINTF("***** Rising Edge Test \n");
@@ -174,7 +175,10 @@ Case cases[] = {
 		Case("Interrupt from GPOUT_2 -> GPIN_2", InterruptInTest<PIN_GPIN_2,PIN_GPOUT_2>,greentea_failure_handler),
 		Case("Interrupt from GPIN_2 -> GPOUT_2", InterruptInTest<PIN_GPOUT_2,PIN_GPIN_2>,greentea_failure_handler),
 		Case("Interrupt from GPOUT_1 -> GPIN_1", InterruptInTest<PIN_GPIN_1,PIN_GPOUT_1_PWM>,greentea_failure_handler),
-		Case("Interrupt from GPIN_1 -> GPOUT_1", InterruptInTest<PIN_GPOUT_1_PWM,PIN_GPIN_1>,greentea_failure_handler),
+
+		// Note: Don't do GPIN_1 -> GPOUT_1 because the R-C filter attached to GPOUT_1 plus the resistor between GPOUT_1 and GPIN_1
+		// can cause the logic level on GPOUT_1 to be between 1 and 0 for a millisecond or more after GPOUT_1 changes state.
+
 		Case("Interrupt from GPOUT_0 -> GPIN_0", InterruptInTest<PIN_GPIN_0,PIN_GPOUT_0>,greentea_failure_handler),
 		Case("Interrupt from GPIN_0 -> GPOUT_0", InterruptInTest<PIN_GPOUT_0,PIN_GPIN_0>,greentea_failure_handler),
 

CI-Shield-Tests/host_tests/uart_test.py

@@ -59,7 +59,7 @@ def _callback_verify_repeated_test_string(self, key: str, value: str, timestamp)
         if rx_data == expected_rx_data:
             self.send_kv('verify_repeated_test_string', 'complete')
         else:
-            self.logger.prn_err(f"Expected '{expected_rx_data}', got '{rx_data}'!")
+            self.logger.prn_err(f"Expected {expected_rx_data!r}, got {rx_data!r}!")
             self.send_kv('verify_repeated_test_string', 'failed')
 
     def _callback_send_test_string(self, key: str, value: str, timestamp):