Skip to content

Commit 080fae1

Browse files
authored
Do not mix conda-forge, defaults and nvidia conda channels in linux_cuda_wheel job
1 parent 0535b00 commit 080fae1

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

.github/workflows/linux_cuda_wheel.yaml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ jobs:
7070
# We test against 12.6 and 13.0 to avoid having too big of a CI matrix,
7171
# but for releases we should add 12.8.
7272
cuda-version: ['12.6', '13.0']
73-
# TODO: put back ffmpeg 5 https://github.com/pytorch/torchcodec/issues/325
74-
ffmpeg-version-for-tests: ['4.4.2', '6', '7', '8.0']
73+
ffmpeg-version-for-tests: ['4.4.2', '5', '6', '7', '8.0']
7574

7675
container:
7776
image: "pytorch/manylinux2_28-builder:cuda${{ matrix.cuda-version }}"
@@ -89,12 +88,17 @@ jobs:
8988
name: meta-pytorch_torchcodec__${{ matrix.python-version }}_cu${{ env.cuda_version_without_periods }}_x86_64
9089
path: pytorch/torchcodec/dist/
9190
- name: Setup miniconda using test-infra
92-
uses: pytorch/test-infra/.github/actions/setup-miniconda@main
91+
uses: conda-incubator/setup-miniconda@v3
9392
with:
93+
# Using miniforge instead of miniconda ensures that the default
94+
# conda channel is conda-forge instead of main/default. This ensures
95+
# ABI consistency between dependencies:
96+
# https://conda-forge.org/docs/user/transitioning_from_defaults/
97+
miniforge-version: latest
9498
python-version: ${{ matrix.python-version }}
9599
# We install conda packages at the start because otherwise conda may have conflicts with dependencies.
96100
# Note: xorg-libxau was addded to fix a problem with ffmpeg 4. We should consider removing it.
97-
default-packages: "nvidia/label/cuda-${{ matrix.cuda-version }}.0::libnpp nvidia::cuda-nvrtc=${{ matrix.cuda-version }} nvidia::cuda-toolkit=${{ matrix.cuda-version }} nvidia::cuda-cudart=${{ matrix.cuda-version }} nvidia::cuda-driver-dev=${{ matrix.cuda-version }} conda-forge::ffmpeg=${{ matrix.ffmpeg-version-for-tests }} conda-forge::xorg-libxau"
101+
default-packages: "libnpp cuda-nvrtc=${{ matrix.cuda-version }} cuda-toolkit=${{ matrix.cuda-version }} cuda-cudart=${{ matrix.cuda-version }} cuda-driver-dev=${{ matrix.cuda-version }} ffmpeg=${{ matrix.ffmpeg-version-for-tests }} xorg-libxau"
98102
- name: Check env
99103
run: |
100104
${CONDA_RUN} env

0 commit comments

Comments
 (0)