lint

Author: NicolasHug

.github/workflows/windows_wheel.yaml

@@ -188,7 +188,7 @@ jobs:
 
         # Prepare conda
         set +x && eval "$($(which conda) shell.bash hook)" && set -x
-        
+
         echo '::group::Create build environment'
         conda create \
           --name ci \
@@ -199,29 +199,29 @@ jobs:
 
         # Install PyTorch
         python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
-        
+
         # Install build dependencies
         conda install cmake pkg-config pybind11 "ffmpeg=${{ matrix.ffmpeg-version-for-tests }}" -c conda-forge
-        
+
         # Ensure FFmpeg DLLs are in PATH for Windows
         conda_env_path=$(conda info --base)/envs/ci
         library_bin_path="$conda_env_path/Library/bin"
         echo "Adding conda Library/bin to PATH: $library_bin_path"
         echo "$library_bin_path" >> $GITHUB_PATH
-        
+
         # Verify FFmpeg is available
         ffmpeg -version
-        
+
         # Install torchcodec from source in development mode
         pip install -e ".[dev]" --no-build-isolation -vv
-        
+
         # Add torchcodec source directory to DLL search path for Windows
         torchcodec_dll_path="$(pwd)/src/torchcodec"
         echo "Adding torchcodec DLL path: $torchcodec_dll_path"
         export PATH="$torchcodec_dll_path:$PATH"
-        
+
         # Test torchcodec import with detailed error reporting
         python -c "import torch; import torchcodec"
-        
+
         # Run tests
         pytest test -vvv

setup.py

@@ -135,9 +135,14 @@ def _build_all_extensions_with_cmake(self):
             ["cmake", str(_ROOT_DIR)] + cmake_args, cwd=self.build_temp
         )
         print("Calling cmake --build", flush=True)
-        subprocess.check_call(["cmake", "--build", ".","--config",cmake_build_type], cwd=self.build_temp)
+        subprocess.check_call(
+            ["cmake", "--build", ".", "--config", cmake_build_type], cwd=self.build_temp
+        )
         print("Calling cmake --install", flush=True)
-        subprocess.check_call(["cmake", "--install", ".","--config",cmake_build_type], cwd=self.build_temp)
+        subprocess.check_call(
+            ["cmake", "--install", ".", "--config", cmake_build_type],
+            cwd=self.build_temp,
+        )
 
     def copy_extensions_to_source(self):
         """Copy built extensions from temporary folder back into source tree.

src/torchcodec/_core/ops.py

@@ -6,8 +6,6 @@
 
 import io
 import json
-import os
-import sys
 import warnings
 from types import ModuleType
 from typing import List, Optional, Tuple, Union
@@ -49,27 +47,20 @@ def load_torchcodec_shared_libraries():
         custom_ops_library_name = f"libtorchcodec_custom_ops{ffmpeg_major_version}"
         pybind_ops_library_name = f"libtorchcodec_pybind_ops{ffmpeg_major_version}"
         try:
-            print(f"Loading {decoder_library_name}", flush=True)
             torch.ops.load_library(_get_extension_path(decoder_library_name))
-            print(f"successfully loaded {decoder_library_name}", flush=True)
-            
-            print(f"Loading {custom_ops_library_name}", flush=True)
             torch.ops.load_library(_get_extension_path(custom_ops_library_name))
-            print(f"successfully loaded {custom_ops_library_name}", flush=True)
 
-            print(f"Loading {pybind_ops_library_name}", flush=True)
             pybind_ops_library_path = _get_extension_path(pybind_ops_library_name)
             global _pybind_ops
             _pybind_ops = _load_pybind11_module(
                 pybind_ops_module_name, pybind_ops_library_path
             )
-            print(f"successfully loaded {pybind_ops_library_name}", flush=True)
             return
         except Exception as e:
             # TODO: recording and reporting exceptions this way is OK for now as  it's just for debugging,
             # but we should probably handle that via a proper logging mechanism.
             exceptions.append((ffmpeg_major_version, e))
-    
+
     traceback = (
         "\n[start of libtorchcodec loading traceback]\n"
         + "\n".join(f"FFmpeg version {v}: {str(e)}" for v, e in exceptions)