Fix Lint job #333
Merged
Fix Lint job #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Nov 5, 2024
Comment on lines
-39
to
-40
| # Continue on error to display the formatting diff in case lint fails. | ||
| continue-on-error: true |
Contributor
Author
There was a problem hiding this comment.
This is what prevented the CI to be red when the pre-commit job failed.
We'll have to find a better way to display the formatting diff.
ahmadsharif1
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our lint job is broken on main: see latest commit with a failing pre-commit job https://github.com/pytorch/torchcodec/actions/runs/11672509149/job/32501275316
It's failing, but green. This is because we have deactivated the ability for the job to properly fail
This PR:
736bdc4(#333)