Merge branch 'main' of https://github.com/blauerPCL/ALAppExtensions into SL-Migration-Vendor1099

Author: blauerPCL

.github/AL-Go-Settings.json

@@ -6,7 +6,7 @@
   "runs-on": "windows-latest",
   "cacheImageName": "",
   "UsePsSession": false,
-  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/28.0.40773.0/base",
+  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/28.0.41461.0/base",
   "country": "base",
   "useProjectDependencies": true,
   "repoVersion": "28.0",

Apps/CZ/AdvancePaymentsLocalization/app/Src/Reports/SalesAdvanceLetterEmail.docx

@@ -41,6 +41,7 @@ codeunit 31252 "Data Class. Eval. Handler CZA"
         AssemblyLine: Record "Assembly Line";
         AssemblySetup: Record "Assembly Setup";
 #endif
+        CopyItemBuffer: Record "Copy Item Buffer";
         CapacityLedgerEntry: Record "Capacity Ledger Entry";
         DataExchFieldMapping: Record "Data Exch. Field Mapping";
         DefaultDimension: Record "Default Dimension";
@@ -79,6 +80,7 @@ codeunit 31252 "Data Class. Eval. Handler CZA"
 #pragma warning restore AL0432
 #endif
         DataClassificationMgt.SetFieldToNormal(Database::"Capacity Ledger Entry", CapacityLedgerEntry.FieldNo("User ID CZA"));
+        DataClassificationMgt.SetFieldToNormal(Database::"Copy Item Buffer", CopyItemBuffer.FieldNo("Auto Create Dimension CZA"));
         DataClassificationMgt.SetFieldToNormal(Database::"Data Exch. Field Mapping", DataExchFieldMapping.FieldNo("Date Formula CZA"));
         DataClassificationMgt.SetFieldToNormal(Database::"Default Dimension", DefaultDimension.FieldNo("Automatic Create CZA"));
         DataClassificationMgt.SetFieldToNormal(Database::"Default Dimension", DefaultDimension.FieldNo("Dim. Description Field ID CZA"));

Apps/CZ/AdvancePaymentsLocalization/app/Src/Reports/SalesAdvanceVATDocEmail.docx

@@ -328,6 +328,31 @@ codeunit 31392 "Default Dimension Handler CZA"
             until AutoDefaultDimension.Next() = 0;
     end;
 
+    [EventSubscriber(ObjectType::Codeunit, Codeunit::"Copy Item", 'OnCopyItemOnBeforeTargetItemInsert', '', false, false)]
+    local procedure ItemCopyOnCopyItemOnBeforeTargetItemInsert(var CopyItemBuffer: Record "Copy Item Buffer")
+    var
+        AutoDefaultDimension: Record "Default Dimension";
+    begin
+        if not CopyItemBuffer.Dimensions then
+            exit;
+
+        AutoDefaultDimension.SetRange("Table ID", Database::Item);
+        AutoDefaultDimension.SetRange("No.", '');
+        AutoDefaultDimension.SetRange("Automatic Create CZA", true);
+        if AutoDefaultDimension.IsEmpty() then
+            exit;
+
+        CopyItemBuffer.Dimensions := false;
+        CopyItemBuffer."Auto Create Dimension CZA" := true;
+    end;
+
+    [EventSubscriber(ObjectType::Codeunit, Codeunit::"Copy Item", 'OnAfterCopyItem', '', false, false)]
+    local procedure ItemCopyOnAfterCopyItem(var CopyItemBuffer: Record "Copy Item Buffer"; SourceItem: Record Item; var TargetItem: Record Item)
+    begin
+        if CopyItemBuffer."Auto Create Dimension CZA" then
+            CopyItemDimensions(SourceItem, TargetItem."No.");
+    end;
+
     local procedure SetRequestRunFalse(TableID: Integer)
     begin
         case TableID of
@@ -378,6 +403,23 @@ codeunit 31392 "Default Dimension Handler CZA"
         end;
     end;
 
+    local procedure CopyItemDimensions(FromItem: Record Item; ToItemNo: Code[20])
+    var
+        DefaultDimension: Record "Default Dimension";
+        NewDefaultDimension: Record "Default Dimension";
+    begin
+        DefaultDimension.SetRange("Table ID", Database::Item);
+        DefaultDimension.SetRange("No.", FromItem."No.");
+        if DefaultDimension.FindSet() then
+            repeat
+                if not NewDefaultDimension.Get(Database::Item, ToItemNo, DefaultDimension."Dimension Code") then begin
+                    NewDefaultDimension.TransferFields(DefaultDimension);
+                    NewDefaultDimension."No." := ToItemNo;
+                    NewDefaultDimension.Insert();
+                end;
+            until DefaultDimension.Next() = 0;
+    end;
+
     var
         DimensionAutoUpdateMgtCZA: Codeunit "Dimension Auto.Update Mgt. CZA";
 }

Apps/CZ/AdvancePaymentsLocalization/app/Src/Reports/SalesInvoicewithAdvEmail.docx

@@ -416,9 +416,9 @@ codeunit 31370 "G/L Entry Post Application CZA"
     local procedure IsAppliedEntry(GLEntry: Record "G/L Entry"; ApplyingGLEntry: Record "G/L Entry") IsOk: Boolean
     begin
         IsOk :=
+            (GLEntry."Entry No." <> ApplyingGLEntry."Entry No.") and
             (GLEntry."G/L Account No." = ApplyingGLEntry."G/L Account No.") and
-            ((GLEntry.Amount <> 0) and ((GLEntry.Amount * ApplyingGLEntry.Amount) < 0)) or
-            (GLEntry.Amount = 0);
+            ((GLEntry.Amount * ApplyingGLEntry.Amount) <= 0);
         OnAfterIsAppliedEntry(GLEntry, ApplyingGLEntry, IsOk);
     end;
 

Apps/CZ/AdvancedLocalizationPack/app/Src/Codeunits/DataClassEvalHandlerCZA.Codeunit.al

@@ -0,0 +1,13 @@
+namespace Microsoft.Inventory.Item;
+
+tableextension 31073 "Copy Item Buffer CZA" extends "Copy Item Buffer"
+{
+    fields
+    {
+        field(31238; "Auto Create Dimension CZA"; Boolean)
+        {
+            Caption = 'Auto Create Dimension';
+            DataClassification = SystemMetadata;
+        }
+    }
+}

Apps/CZ/AdvancedLocalizationPack/app/Src/Codeunits/DefaultDimensionHandlerCZA.Codeunit.al

@@ -36,6 +36,7 @@ codeunit 31362 "Match Bank Payment CZB"
         SummaryGenJournalLine: Record "Gen. Journal Line";
         BankAccountNo: Code[20];
         MinAmount, MaxAmount : Decimal;
+        AppliesToIDTok: Label '%1%2', Locked = true, MaxLength = 50;
 
     local procedure Code()
     begin
@@ -205,7 +206,8 @@ codeunit 31362 "Match Bank Payment CZB"
                             GenJournalLine.Validate("Applies-to Doc. Type", TempMatchBankPaymentBufferCZB."Document Type");
                             GenJournalLine.SetSuppressCommit(true);
                             GenJournalLine.Validate("Applies-to Doc. No.", TempMatchBankPaymentBufferCZB."Document No.");
-                        end;
+                        end else
+                            GenJournalLine.Validate("Applies-to ID", BuildAppliesToID(GenJournalLine));
                         if BankAccount."Dimension from Apply Entry CZB" then
                             GenJournalLine.Validate("Dimension Set ID", TempMatchBankPaymentBufferCZB."Dimension Set ID");
                         if GenJournalLine."Currency Code" <> OriginalGenJournalLine."Currency Code" then
@@ -488,6 +490,11 @@ codeunit 31362 "Match Bank Payment CZB"
         MaxAmount := Round(MaxAmount);
     end;
 
+    local procedure BuildAppliesToID(GenJournalLine: Record "Gen. Journal Line"): Code[50]
+    begin
+        exit(CopyStr(StrSubstNo(AppliesToIDTok, GenJournalLine."Document No.", Format(GenJournalLine."Line No.")), 1, MaxStrLen(GenJournalLine."Applies-to ID")));
+    end;
+
     [IntegrationEvent(false, false)]
     local procedure OnAfterFillMatchBankPaymentBuffer(var TempMatchBankPaymentBufferCZB: Record "Match Bank Payment Buffer CZB"; SearchRuleLineCZB: Record "Search Rule Line CZB"; var GenJournalLine: Record "Gen. Journal Line"; MinAmount: Decimal; MaxAmount: Decimal)
     begin

Apps/CZ/AdvancedLocalizationPack/app/Src/Codeunits/GLEntryPostApplicationCZA.Codeunit.al

@@ -25,11 +25,10 @@ codeunit 31037 "Bank Operations Functions CZL"
         IdentificationIncorrectChecksumErr: Label 'Bank account identification has incorrect checksum.';
         FirstHyphenErr: Label 'Bank account no. must not start with character "-".';
 
-    procedure CreateVariableSymbol(Input: Code[35]): Code[10]
+    procedure CreateVariableSymbol(Input: Code[35]) VariableSymbol: Code[10]
     begin
-        if Input = '' then
-            exit('');
-        exit(CopyStr(TrimLeft(NumbersOnly(Input), '0'), 1, 10));
+        VariableSymbol := CopyStr(TrimLeft(NumbersOnly(Input), '0'), 1, 10);
+        OnCreateVariableSymbol(Input, VariableSymbol);
     end;
 
     local procedure NumbersOnly(Input: Text): Text
@@ -223,4 +222,9 @@ codeunit 31037 "Bank Operations Functions CZL"
 
         exit(OutputSum mod 11);
     end;
+
+    [IntegrationEvent(false, false)]
+    local procedure OnCreateVariableSymbol(Input: Code[35]; var VariableSymbol: Code[10])
+    begin
+    end;
 }