[Event Request] [W1] codeunit 378 "Transfer Extended Text" - OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines

[AleksandricMarko]

Why do you need this change?

Our customers want the extended text feature to work similiar to the Sales Documents where they have on Date Field at the header level that controls which extended texts are found.

Therefore we need a way to change the DocDate that is used when ReadExtTextLines is called for a JobPlanningLine.

Describe the request

Could you update the event OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines to provide a way to overwrite the "Document Date" that is used to check for extended texts in procedure JobCheckIfAnyExtText?

procedure JobCheckIfAnyExtText(var JobPlanningLine: Record "Job Planning Line"; Unconditionally: Boolean; Job: Record Job) Result: Boolean
var
ExtTextHeader: Record "Extended Text Header";
IsHandled: Boolean;
DocDate: Date;
begin
...
case JobPlanningLine.Type of
JobPlanningLine.Type::Text:
ExtTextHeader.SetRange("Table Name", ExtTextHeader."Table Name"::"Standard Text");
JobPlanningLine.Type::Item:
ExtTextHeader.SetRange("Table Name", ExtTextHeader."Table Name"::Item);
JobPlanningLine.Type::Resource:
ExtTextHeader.SetRange("Table Name", ExtTextHeader."Table Name"::Resource);
JobPlanningLine.Type::"G/L Account":
ExtTextHeader.SetRange("Table Name", ExtTextHeader."Table Name"::"G/L Account");
end;
ExtTextHeader.SetRange("No.", JobPlanningLine."No.");
ExtTextHeader.SetRange(Job, true);
//+Change
//-OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(ExtTextHeader, Job, JobPlanningLine, Unconditionally, MakeUpdateRequired);
//-exit(ReadExtTextLines(ExtTextHeader, JobPlanningLine."Document Date", Job."Language Code"));
DocDate := JobPlanningLine."Document Date";
OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(ExtTextHeader, Job, JobPlanningLine, Unconditionally, MakeUpdateRequired, DocDate);
exit(ReadExtTextLines(ExtTextHeader, DocDate, Job."Language Code"));
//-Change
end;
[IntegrationEvent(false, false)]
//+Change
//-local procedure OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(var ExtendedTextHeader: Record "Extended Text Header"; var Job: Record Job; var JobPlanningLine: Record "Job Planning Line"; Unconditionally: Boolean; var MakeUpdateRequired: Boolean)
local procedure OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(var ExtendedTextHeader: Record "Extended Text Header"; var Job: Record Job; var JobPlanningLine: Record "Job Planning Line"; Unconditionally: Boolean; var MakeUpdateRequired: Boolean; var DocDate: Date)
//-Change
begin
end;
Internal work item: AB#613386

[AleksandricMarko]

✅ Analysis Complete - Approved for Implementation

Issue Type: event-request (Regular)
Status: READY FOR TEAM IMPLEMENTATION

Analysis Summary

Requirements: ✅ All met

• Problem Statement: Customers need date filtering for extended texts in Job Planning Lines (like Sales Documents)
• Proposed Code: Provided with exact location and signature change
• Use Case: Allow subscribers to override document date for extended text filtering

Codebase Findings: ✅ All valid

• Target: Codeunit 378 "Transfer Extended Text"
• Procedure: JobCheckIfAnyExtText (lines 720-807) - LOCAL procedure
• Event: OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines (line 1106-1108)
• Layer: W1 (BaseApp)
• No obsolete/protected code
• No parameter type violations (no RecordRef)
• No unsafe code blocks

Feasibility: ✅ CAN IMPLEMENT

Implementation Details

File: Apps/W1/BaseApp/Foundation/ExtendedText/TransferExtendedText.Codeunit.al

Change 1 - Update Event Signature (line 1106):

Current:

[IntegrationEvent(false, false)]
local procedure OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(var ExtendedTextHeader: Record "Extended Text Header"; var Job: Record Job; var JobPlanningLine: Record "Job Planning Line"; Unconditionally: Boolean; var MakeUpdateRequired: Boolean)
begin
end;

Updated:

[IntegrationEvent(false, false)]
local procedure OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(var ExtendedTextHeader: Record "Extended Text Header"; var Job: Record Job; var JobPlanningLine: Record "Job Planning Line"; Unconditionally: Boolean; var MakeUpdateRequired: Boolean; var DocDate: Date)
begin
end;

Change 2 - Update Event Call (lines 783-784):

Current:

OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(ExtTextHeader, Job, JobPlanningLine, Unconditionally, MakeUpdateRequired);
exit(ReadExtTextLines(ExtTextHeader, JobPlanningLine."Document Date", Job."Language Code"));

Updated:

DocDate := JobPlanningLine."Document Date";
OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(ExtTextHeader, Job, JobPlanningLine, Unconditionally, MakeUpdateRequired, DocDate);
exit(ReadExtTextLines(ExtTextHeader, DocDate, Job."Language Code"));

Change 3 - Add DocDate variable (line 720):

Add DocDate: Date; to the local variable declarations in the JobCheckIfAnyExtText procedure.

Benefits

✅ Aligns Job extended text feature with Sales/Purchase/Reminder document types
✅ Allows customers to customize date filtering logic via extensions
✅ Follows established pattern in same codeunit
✅ No breaking changes (parameter is var, optional for subscribers)

Team Assignment: SCM
Module: Projects/Job Planning

---

Next Step: Assign to SCM team for implementation

[AleksandricMarko]

✅ Analysis Complete - Approved for Implementation

This event request has been analyzed and approved. The proposed change to add a var DocDate: Date parameter to the OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines event is feasible and will be implemented.

What will be implemented:

• Add DocDate parameter to event signature in Codeunit 378 "Transfer Extended Text"
• Update event call in JobCheckIfAnyExtText procedure to allow subscribers to customize the document date used for extended text filtering
• Aligns Job extended text feature with Sales/Purchase document functionality

Team: SCM
Status: Ready for implementation

[AleksandricMarko]

✅ Analysis complete - approved for implementation

Implementation:

Update event signature in Codeunit 378 "Transfer Extended Text":

[IntegrationEvent(false, false)]
local procedure OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(var ExtendedTextHeader: Record "Extended Text Header"; var Job: Record Job; var JobPlanningLine: Record "Job Planning Line"; Unconditionally: Boolean; var MakeUpdateRequired: Boolean; var DocDate: Date)
begin
end;

Update the event call:

DocDate := JobPlanningLine."Document Date";
OnJobCheckIfAnyExtTextOnBeforeReadExtTextLines(ExtTextHeader, Job, JobPlanningLine, Unconditionally, MakeUpdateRequired, DocDate);
exit(ReadExtTextLines(ExtTextHeader, DocDate, Job."Language Code"));