Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Success always false in TelemetryClient.track_request? #74

@UpQuark

Description

@UpQuark

Hi folks,

I noticed a little oddity while overriding code from telemetry_client.rb.

The ternary operator (full snippet below) seems to use = rather than == and so it seems like success will always be false.
:success => success = nil ? true : success,

telemetry_client.rb

def track_request(id, start_time, duration, response_code, success, options={})
  data = Channel::Contracts::RequestData.new(
    :success => success = nil ? true : success,
    # etc ...
  )

  self.channel.write(data, self.context)
end

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions