Remove get_js_plugins and related types+functions (#6879)

Co-authored-by: Amaury Chamayou <[email protected]>

Author: eddyashton

CMakeLists.txt

@@ -282,8 +282,6 @@ set(CCF_JS_SOURCES
     ${CCF_DIR}/src/js/core/wrapped_value.cpp
     ${CCF_DIR}/src/js/core/runtime.cpp
     ${CCF_DIR}/src/js/core/context.cpp
-    ${CCF_DIR}/src/js/no_plugins.cpp
-    ${CCF_DIR}/src/js/ffi_plugins.cpp
     ${CCF_DIR}/src/js/extensions/console.cpp
     ${CCF_DIR}/src/js/extensions/math/random.cpp
     ${CCF_DIR}/src/js/extensions/snp_attestation.cpp

doc/build_apps/api.rst

@@ -5,7 +5,6 @@ A CCF application is composed of the following:
 
 - The :ref:`Application Entry Point <build_apps/api:Application Entry Point>` which creates the application in CCF.
 - A collection of :cpp:class:`endpoints <ccf::endpoints::Endpoint>` handling HTTP requests and grouped in a single :cpp:class:`registry <ccf::endpoints::EndpointRegistry>`. An :cpp:class:`endpoint <ccf::endpoints::Endpoint>` reads and writes to the key-value store via the :ref:`Key-Value Store API <build_apps/kv/api:Key-Value Store API>`.
-- An optional set of :ref:`JavaScript FFI Plugins <build_apps/api:JavaScript FFI Plugins>` that can be registered to extend the built-in JavaScript API surface.
 
 Application Entry Point
 -----------------------

include/ccf/app_interface.h

@@ -4,7 +4,6 @@
 
 #include "ccf/ccf_deprecated.h"
 #include "ccf/common_endpoint_registry.h"
-#include "ccf/js_plugin.h"
 #include "ccf/node_context.h"
 
 #include <memory>
@@ -54,11 +53,4 @@ namespace ccf
   std::unique_ptr<ccf::endpoints::EndpointRegistry> make_user_endpoints(
     ccf::AbstractNodeContext& context);
   // SNIPPET_END: app_interface
-
-  /** To be implemented by the application.
-   *
-   * @return Vector of JavaScript FFI plugins
-   */
-  CCF_DEPRECATED("Deprecated from 6.0.0")
-  std::vector<ccf::js::FFIPlugin> get_js_plugins();
 }

include/ccf/js_plugin.h

@@ -15,7 +15,6 @@
 #include "indexing/enclave_lfs_access.h"
 #include "indexing/historical_transaction_fetcher.h"
 #include "interface.h"
-#include "js/ffi_plugins.h"
 #include "js/interpreter_cache.h"
 #include "node/acme_challenge_frontend.h"
 #include "node/historical_queries.h"
@@ -197,13 +196,6 @@ namespace ccf
       rpc_map->register_frontend<ccf::ActorsType::acme_challenge>(
         std::make_unique<ccf::ACMERpcFrontend>(network, *context));
 
-// Suppress error about use of deprecated get_js_plugins(). This call, and all
-// references to FFIPlugins, should be removed after 6.0.0
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-      ccf::js::register_ffi_plugins(ccf::get_js_plugins());
-#pragma clang diagnostic pop
-
       LOG_TRACE_FMT("Initialize node");
       node->initialize(
         consensus_config,

src/enclave/enclave.h

@@ -9,7 +9,6 @@
 #include "ccf/js/extensions/console.h"
 #include "ccf/js/tx_access.h"
 #include "enclave/enclave_time.h"
-#include "js/ffi_plugins.h"
 #include "js/global_class_ids.h"
 
 #include <chrono>
@@ -64,12 +63,6 @@ namespace ccf::js::core
     }
     JS_SetContextOpaque(ctx, this);
 
-    for (auto& plugin : ffi_plugins)
-    {
-      LOG_DEBUG_FMT("Extending JS context with plugin {}", plugin.name);
-      plugin.extend(*this);
-    }
-
     JS_SetModuleLoaderFunc(rt, nullptr, load_module_via_context, this);
   }