Pass nullptr as nullT when creating thread_data that's of ConcurrentQueue<SSDThreadData*> type, otherwise the default null_T is uninitialized, could point to arbitraty memory (#408)

ltan1ms · web-flow · commit 1eac7026fb49 · 2023-08-01T12:03:53.000-07:00
diff --git a/src/pq_flash_index.cpp b/src/pq_flash_index.cpp
@@ -41,7 +41,7 @@ namespace diskann
 
 template <typename T, typename LabelT>
 PQFlashIndex<T, LabelT>::PQFlashIndex(std::shared_ptr<AlignedFileReader> &fileReader, diskann::Metric m)
-    : reader(fileReader), metric(m)
+    : reader(fileReader), metric(m), thread_data(nullptr)
 {
     if (m == diskann::Metric::COSINE || m == diskann::Metric::INNER_PRODUCT)
     {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ namespace diskann`
`41`	`41`
`42`	`42`	`template <typename T, typename LabelT>`
`43`	`43`	`PQFlashIndex<T, LabelT>::PQFlashIndex(std::shared_ptr<AlignedFileReader> &fileReader, diskann::Metric m)`
`44`		`- : reader(fileReader), metric(m)`
	`44`	`+ : reader(fileReader), metric(m), thread_data(nullptr)`
`45`	`45`	`{`
`46`	`46`	`if (m == diskann::Metric::COSINE \|\| m == diskann::Metric::INNER_PRODUCT)`
`47`	`47`	`{`