Skip to content

Commit 61ff753

Browse files
committed
fix is
1 parent ab22c6e commit 61ff753

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.github/workflows/validate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
run: |
3333
pip install -r tests/requirements.txt
3434
pytest tests --doctest-modules --cov-report=xml --cov-report=html
35-
- name: Analysing the samples with pylint
35+
- name: Analysing the samples/tests with pylint
3636
run: |
3737
pip install -r samples/requirements.txt
3838
pylint --disable=missing-function-docstring,missing-class-docstring samples tests

tests/test_feature_manager.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def test_duplicate_feature_flags_last_wins(self):
180180
feature_manager = FeatureManager(feature_flags)
181181

182182
# The last flag should win (enabled: true)
183-
assert feature_manager.is_enabled("DuplicateFlag") == True
183+
assert feature_manager.is_enabled("DuplicateFlag") is True
184184

185185
# Should only list unique names
186186
flag_names = feature_manager.list_feature_flag_names()
@@ -218,7 +218,7 @@ def test_duplicate_feature_flags_last_wins_disabled(self):
218218
feature_manager = FeatureManager(feature_flags)
219219

220220
# The last flag should win (enabled: false)
221-
assert feature_manager.is_enabled("DuplicateFlag") == False
221+
assert feature_manager.is_enabled("DuplicateFlag") is False
222222

223223
def test_duplicate_feature_flags_mixed_with_unique(self):
224224
"""Test behavior with a mix of duplicate and unique feature flags."""
@@ -261,12 +261,12 @@ def test_duplicate_feature_flags_mixed_with_unique(self):
261261
feature_manager = FeatureManager(feature_flags)
262262

263263
# Test unique flags work as expected
264-
assert feature_manager.is_enabled("UniqueFlag1") == True
265-
assert feature_manager.is_enabled("UniqueFlag2") == False
266-
assert feature_manager.is_enabled("UniqueFlag3") == True
264+
assert feature_manager.is_enabled("UniqueFlag1") is True
265+
assert feature_manager.is_enabled("UniqueFlag2") is False
266+
assert feature_manager.is_enabled("UniqueFlag3") is True
267267

268268
# Test duplicate flag - last should win (enabled: true)
269-
assert feature_manager.is_enabled("DuplicateFlag") == True
269+
assert feature_manager.is_enabled("DuplicateFlag") is True
270270

271271
# Test list includes all unique names
272272
flag_names = feature_manager.list_feature_flag_names()

tests/test_feature_manager_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ async def test_duplicate_feature_flags_last_wins_async(self):
210210
feature_manager = FeatureManager(feature_flags)
211211

212212
# The last flag should win (enabled: true)
213-
assert await feature_manager.is_enabled("DuplicateFlag") == True
213+
assert await feature_manager.is_enabled("DuplicateFlag") is True
214214

215215
# Should only list unique names
216216
flag_names = feature_manager.list_feature_flag_names()
@@ -249,7 +249,7 @@ async def test_duplicate_feature_flags_last_wins_disabled_async(self):
249249
feature_manager = FeatureManager(feature_flags)
250250

251251
# The last flag should win (enabled: false)
252-
assert await feature_manager.is_enabled("DuplicateFlag") == False
252+
assert await feature_manager.is_enabled("DuplicateFlag") is False
253253

254254

255255
class AlwaysOn(FeatureFilter):

0 commit comments

Comments
 (0)