tag asserts for 2.70 (#25764)

pnpm run policy-check:asserts

Author: dannimad

packages/dds/tree/src/feature-libraries/chunked-forest/codec/compressedEncode.ts

@@ -456,7 +456,7 @@ export const incrementalFieldEncoder: FieldEncoder = {
 	): void {
 		assert(
 			context.incrementalEncoder !== undefined,
-			"incremental encoder must be defined to use incrementalFieldEncoder",
+			0xc88 /* incremental encoder must be defined to use incrementalFieldEncoder */,
 		);
 
 		const chunkReferenceIds = context.incrementalEncoder.encodeIncrementalField(

packages/dds/tree/src/feature-libraries/forest-summary/incrementalSummaryBuilder.ts

@@ -529,7 +529,7 @@ export class ForestIncrementalSummaryBuilder implements IncrementalEncoderDecode
 		chunkDecoder: (encoded: EncodedFieldBatch) => TreeChunk,
 	): TreeChunk {
 		const ChunkLoadProperties = this.loadedChunksMap.get(`${referenceId}`);
-		assert(ChunkLoadProperties !== undefined, "Encoded incremental chunk not found");
+		assert(ChunkLoadProperties !== undefined, 0xc86 /* Encoded incremental chunk not found */);
 		const chunk = chunkDecoder(ChunkLoadProperties.encodedContents);
 
 		// Account for the reference about to be added in `chunkTrackingPropertiesMap`

packages/dds/tree/src/simple-tree/api/incrementalAllowedTypes.ts

@@ -100,7 +100,7 @@ export function getShouldIncrementallySummarizeAllowedTypes(
 		);
 		assert(
 			allowedTypes !== undefined,
-			"Non object nodes with fields should only have one allowedTypes entry",
+			0xc87 /* Non object nodes with fields should only have one allowedTypes entry */,
 		);
 		return isIncrementalSummaryHintInAllowedTypes(allowedTypes);
 	};

packages/loader/container-loader/src/container.ts

@@ -2236,7 +2236,7 @@ export class Container
 			// Signal-based Audience does not wait for ops. So provide clientId
 			// as soon as possible.
 			const clientId = this.connectionStateHandler.pendingClientId;
-			assert(clientId !== undefined, "catching up without clientId");
+			assert(clientId !== undefined, 0xc89 /* catching up without clientId */);
 			this.signalAudience.setCurrentClientId(clientId);
 		}
 
@@ -2566,7 +2566,10 @@ export class Container
 					case ConnectionState.CatchingUp: {
 						// When catching up, we have a pending clientId, but it
 						// is not usable for ops. Send clientId with canSendOps false.
-						assert(pendingClientConnectionId !== undefined, "catching up without clientId");
+						assert(
+							pendingClientConnectionId !== undefined,
+							0xc8a /* catching up without clientId */,
+						);
 						setConnectionStatus({
 							connectionState,
 							pendingClientConnectionId,
@@ -2580,10 +2583,10 @@ export class Container
 						// When connected, we have an active clientId. Pass it along
 						// with canSendOps true/false based on readonly.
 						const clientConnectionId = this.clientId;
-						assert(clientConnectionId !== undefined, "connected without clientId");
+						assert(clientConnectionId !== undefined, 0xc8b /* connected without clientId */);
 						assert(
 							clientConnectionId === pendingClientConnectionId,
-							"connected with different clientId than pending",
+							0xc8c /* connected with different clientId than pending */,
 						);
 						setConnectionStatus({
 							connectionState,

packages/runtime/container-runtime/src/containerRuntime.ts

@@ -2839,7 +2839,7 @@ export class ContainerRuntime
 				assert(
 					this.getConnectionState !== undefined &&
 						this.getConnectionState() === ConnectionState.CatchingUp,
-					"connection state mismatch between getConnectionState and setConnectionStatus notification",
+					0xc8d /* connection state mismatch between getConnectionState and setConnectionStatus notification */,
 				);
 
 				// Note: Historically when only `setConnectionState` of `IRuntime`

packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts

@@ -458,7 +458,6 @@ export const shortCodeMap = {
 	"0x2e4": "there should be service config for active connection",
 	"0x2e8": "There should be a store context for the op",
 	"0x2e9": "Must call getLocalState() after applying initial states",
-	"0x2ea": "Configuration state should be enabled",
 	"0x2eb": "Summary not supported with configuration disabled",
 	"0x2ec": "Blob must be present in blobsContents",
 	"0x2ed": "There should be a channel context for the op",
@@ -1805,12 +1804,7 @@ export const shortCodeMap = {
 	"0xc23": "Tracked summary properties must be available when tracking a summary",
 	"0xc24": "Already tracking a summary",
 	"0xc25": "Tracked summary properties must not be available when ready to track",
-	"0xc26": "Incremental chunk contents not found",
 	"0xc27": "incremental decoder not available for incremental field decoding",
-	"0xc28": "Incremental chunk data missing",
-	"0xc29": "should return to fields mode when finished encoding",
-	"0xc2a": "incremental encoding must be enabled to use IncrementalFieldShape",
-	"0xc2b": "incremental encoding must be enabled",
 	"0xc2c": "The data store should be locally visible when generating attach summary",
 	"0xc2d": "logger would be in sessionIdOrLogger in this codepath",
 	"0xc2e": "DecomposedContainerForContainerRuntime is not a ContainerRuntime",
@@ -1897,5 +1891,13 @@ export const shortCodeMap = {
 	"0xc82": "Attempting to attach from unexpected state",
 	"0xc83": "Pending blob must be in local cache",
 	"0xc84": "Pending blob must not be in attached state",
-	"0xc85": "bind must be an ISharedObjectHandle"
+	"0xc85": "bind must be an ISharedObjectHandle",
+	"0xc86": "Encoded incremental chunk not found",
+	"0xc87": "Non object nodes with fields should only have one allowedTypes entry",
+	"0xc88": "incremental encoder must be defined to use incrementalFieldEncoder",
+	"0xc89": "catching up without clientId",
+	"0xc8a": "catching up without clientId",
+	"0xc8b": "connected without clientId",
+	"0xc8c": "connected with different clientId than pending",
+	"0xc8d": "connection state mismatch between getConnectionState and setConnectionStatus notification"
 };