Skip to content

Commit 853320d

Browse files
committed
Reduce dependencies of linting
1 parent 22f82b3 commit 853320d

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

fluidBuild.config.cjs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ module.exports = {
8181
"build:test": ["typetests:gen", "tsc"],
8282
"build:test:cjs": ["typetests:gen", "tsc"],
8383
"build:test:esm": ["typetests:gen", "build:esnext"],
84+
// Everything needed for the API of the package to be consumable by its dependencies.
8485
"api": {
8586
dependsOn: ["api-extractor:commonjs", "api-extractor:esnext"],
8687
script: false,
@@ -129,9 +130,10 @@ module.exports = {
129130
},
130131
"check:biome": [],
131132
"check:prettier": [],
132-
// ADO #7297: Review why the direct dependency on 'build:esm:test' is necessary.
133-
// Should 'compile' be enough? compile -> build:test -> build:test:esm
134-
"eslint": ["compile", "build:test:esm"],
133+
// Linting can require resolving imports into dependencies, and thus "^api".
134+
// The lint task does not seem to invalidate properly, so we take a dependency on "build:test:esm" as well so lint will rerun when the code changes.
135+
// This may be related to AB#7297.
136+
"eslint": ["^api", "build:test:esm"],
135137
"good-fences": [],
136138
"format:biome": [],
137139
"format:prettier": [],

packages/dds/tree/package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,10 @@
231231
"...",
232232
"@fluidframework/id-compressor#build:test:esm"
233233
],
234+
"eslint": [
235+
"...",
236+
"@fluidframework/id-compressor#build:test:esm"
237+
],
234238
"ci:build:docs": [
235239
"build:esnext"
236240
]

0 commit comments

Comments
 (0)