Tag asserts for 2.71.0 release. (#25794)

This PR tags asserts for the upcoming 2.71.0 release. Changes generated
with `pnpm run policy-check:asserts`

Author: scottn12

packages/dds/counter/src/counter.ts

@@ -173,13 +173,13 @@ export class SharedCounter
 			if (local) {
 				const pendingOp = this.pendingOps.shift();
 				const messageId = messageContent.localOpMetadata;
-				assert(typeof messageId === "number", "localOpMetadata should be a number");
+				assert(typeof messageId === "number", 0xc8e /* localOpMetadata should be a number */);
 				assert(
 					pendingOp !== undefined &&
 						pendingOp.messageId === messageId &&
 						pendingOp.type === op.type &&
 						pendingOp.incrementAmount === op.incrementAmount,
-					"local op mismatch",
+					0xc8f /* local op mismatch */,
 				);
 			} else {
 				switch (op.type) {
@@ -215,14 +215,17 @@ export class SharedCounter
 	 */
 	protected rollback(content: unknown, localOpMetadata: unknown): void {
 		assertIsIncrementOp(content);
-		assert(typeof localOpMetadata === "number", "localOpMetadata should be a number");
+		assert(
+			typeof localOpMetadata === "number",
+			0xc90 /* localOpMetadata should be a number */,
+		);
 		const pendingOp = this.pendingOps.pop();
 		assert(
 			pendingOp !== undefined &&
 				pendingOp.messageId === localOpMetadata &&
 				pendingOp.type === content.type &&
 				pendingOp.incrementAmount === content.incrementAmount,
-			"op to rollback mismatch with pending op",
+			0xc91 /* op to rollback mismatch with pending op */,
 		);
 		// To rollback the optimistic increment we can increment by the opposite amount.
 		// This will also emit another incremented event with the opposite amount.
@@ -238,6 +241,6 @@ function assertIsIncrementOp(op: unknown): asserts op is IIncrementOperation {
 			"incrementAmount" in op &&
 			op.type === "increment" &&
 			typeof op.incrementAmount === "number",
-		"invalid increment op format",
+		0xc92 /* invalid increment op format */,
 	);
 }

packages/dds/ordered-collection/src/consensusOrderedCollection.ts

@@ -442,7 +442,10 @@ export class ConsensusOrderedCollection<T = any>
 	 * @sealed
 	 */
 	protected rollback(content: unknown, localOpMetadata: unknown): void {
-		assert(typeof localOpMetadata === "function", "localOpMetadata should be a function");
+		assert(
+			typeof localOpMetadata === "function",
+			0xc93 /* localOpMetadata should be a function */,
+		);
 		// A resolve function is passed as the localOpMetadata on this.submitLocalMessage().
 		// On rollback we resolve with undefined and the promises will handle it appropriately.
 		const resolve = localOpMetadata as PendingResolve<T>;

packages/dds/tree/src/shared-tree/independentView.ts

@@ -212,7 +212,7 @@ export function createIndependentTreeAlpha<const TSchema extends ImplicitFieldSc
 		assert(fieldCursors.length === 1, 0xa5b /* must have exactly 1 field in batch */);
 
 		const fieldCursor = oneFromIterable(fieldCursors);
-		assert(fieldCursor !== undefined, "expected exactly one field in batch");
+		assert(fieldCursor !== undefined, 0xc94 /* expected exactly one field in batch */);
 
 		initialize(
 			checkout,

packages/dds/tree/src/simple-tree/node-kinds/object/objectNode.ts

@@ -767,10 +767,13 @@ function applyFieldChange(
 	const proxy =
 		from.kind === "proxy"
 			? from.node
-			: (targetToProxy.get(from.node) ?? fail("missing proxy"));
+			: (targetToProxy.get(from.node) ?? fail(0xc95 /* missing proxy */));
 	const inner = getInnerNode(proxy);
 	const storedSchema = inner.context.schema.nodeSchema.get(brand(schema.identifier));
-	assert(storedSchema instanceof ObjectNodeStoredSchema, "Expected ObjectNodeStoredSchema");
+	assert(
+		storedSchema instanceof ObjectNodeStoredSchema,
+		0xc96 /* Expected ObjectNodeStoredSchema */,
+	);
 
 	if (value === undefined && inner.tryGetField(fieldInfo.storedKey) === undefined) {
 		return;

packages/framework/presence/src/getPresence.ts

@@ -40,17 +40,20 @@ const presenceCompatibility = {
 function assertCompatibilityInvariants(compatibility: ExtensionCompatibilityDetails): void {
 	assert(
 		compatibility.generation === presenceCompatibility.generation,
-		"Presence compatibility generation mismatch.",
+		0xc97 /* Presence compatibility generation mismatch. */,
+	);
+	assert(
+		compatibility.version.startsWith("2."),
+		0xc98 /* Registered version is not major version 2. */,
 	);
-	assert(compatibility.version.startsWith("2."), "Registered version is not major version 2.");
 	assert(
 		Number.parseFloat(compatibility.version.slice(2)) <
 			Number.parseFloat(presenceCompatibility.version.slice(2)),
-		"Registered version is not less than the current version.",
+		0xc99 /* Registered version is not less than the current version. */,
 	);
 	assert(
 		presenceCompatibility.capabilities.size === 0,
-		"Presence capabilities should be empty.",
+		0xc9a /* Presence capabilities should be empty. */,
 	);
 }
 
@@ -91,7 +94,7 @@ class ContainerPresenceManager
 	): never {
 		assert(
 			ourExistingInstantiation.compatibility === presenceCompatibility,
-			"Presence extension called without own compatibility details",
+			0xc9b /* Presence extension called without own compatibility details */,
 		);
 		assertCompatibilityInvariants(newCompatibilityRequest);
 		// There have not yet been any changes that would require action to upgrade.
@@ -184,7 +187,7 @@ function assertContextHasExtensionProvider(
 ): asserts context is FluidDataStoreContextInternal {
 	assert(
 		"getExtension" in context,
-		"Data store context does not implement ContainerExtensionProvider",
+		0xc9c /* Data store context does not implement ContainerExtensionProvider */,
 	);
 }
 

packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts

@@ -1696,7 +1696,6 @@ export const shortCodeMap = {
 	"0xb9e": "entryPoint must be of type IStaticEntryPoint",
 	"0xb9f": "entryPoint must be of type RootDataObject",
 	"0xba0": "No recipient found for local signal",
-	"0xba1": "Extension entry is not of the expected type",
 	"0xba2": "Reentrancy not allowed in BatchRunCounter",
 	"0xba3": "Mismatch in staged state tracking",
 	"0xba4": "local operation must have a pending array",
@@ -1792,7 +1791,6 @@ export const shortCodeMap = {
 	"0xc15": "Expected ObjectNodeStoredSchema",
 	"0xc16": "missing schema for array node",
 	"0xc17": "Expected MapNodeStoredSchema",
-	"0xc18": "Expected ObjectNodeStoredSchema",
 	"0xc19": "Expected FieldSchemaAlpha",
 	"0xc1a": "Expected MapNodeStoredSchema",
 	"0xc1b": "Expected at least two types",
@@ -1883,7 +1881,6 @@ export const shortCodeMap = {
 	"0xc7a": "No pending change stored for this revision",
 	"0xc7b": "missing anchor",
 	"0xc7c": "Unknown modular change format",
-	"0xc7d": "invalid AnnotatedAllowedTypes",
 	"0xc7e": "Pending blob already in redirect table",
 	"0xc7f": "Expected blob to be attached",
 	"0xc80": "Expect uploadAndAttach to be called with either localOnly or uploaded state",
@@ -1899,5 +1896,20 @@ export const shortCodeMap = {
 	"0xc8a": "catching up without clientId",
 	"0xc8b": "connected without clientId",
 	"0xc8c": "connected with different clientId than pending",
-	"0xc8d": "connection state mismatch between getConnectionState and setConnectionStatus notification"
+	"0xc8d": "connection state mismatch between getConnectionState and setConnectionStatus notification",
+	"0xc8e": "localOpMetadata should be a number",
+	"0xc8f": "local op mismatch",
+	"0xc90": "localOpMetadata should be a number",
+	"0xc91": "op to rollback mismatch with pending op",
+	"0xc92": "invalid increment op format",
+	"0xc93": "localOpMetadata should be a function",
+	"0xc94": "expected exactly one field in batch",
+	"0xc95": "missing proxy",
+	"0xc96": "Expected ObjectNodeStoredSchema",
+	"0xc97": "Presence compatibility generation mismatch.",
+	"0xc98": "Registered version is not major version 2.",
+	"0xc99": "Registered version is not less than the current version.",
+	"0xc9a": "Presence capabilities should be empty.",
+	"0xc9b": "Presence extension called without own compatibility details",
+	"0xc9c": "Data store context does not implement ContainerExtensionProvider"
 };