build(client): Tag asserts for release 2.52.0 (#25150)

build(client): Tag asserts for release 2.52.0

---------

Co-authored-by: Jatin Garg <[email protected]>

Author: jatgarg

packages/dds/map/src/mapKernel.ts

@@ -214,7 +214,7 @@ export class MapKernel {
 					const optimisticValue = this.getOptimisticLocalValue(key);
 					assert(
 						optimisticValue !== undefined,
-						"Should never iterate to a key with undefined optimisticValue",
+						0xbf1 /* Should never iterate to a key with undefined optimisticValue */,
 					);
 					return { value: [key, optimisticValue], done: false };
 				}
@@ -637,7 +637,7 @@ export class MapKernel {
 				pendingClear !== undefined &&
 					pendingClear.type === "clear" &&
 					pendingClear === typedLocalOpMetadata,
-				"Unexpected clear rollback",
+				0xbf2 /* Unexpected clear rollback */,
 			);
 			for (const [key] of this.internalIterator()) {
 				this.eventEmitter.emit(
@@ -658,10 +658,10 @@ export class MapKernel {
 			assert(
 				pendingEntry !== undefined &&
 					(pendingEntry.type === "delete" || pendingEntry.type === "lifetime"),
-				"Unexpected pending data for set/delete op",
+				0xbf3 /* Unexpected pending data for set/delete op */,
 			);
 			if (pendingEntry.type === "delete") {
-				assert(pendingEntry === typedLocalOpMetadata, "Unexpected delete rollback");
+				assert(pendingEntry === typedLocalOpMetadata, 0xbf4 /* Unexpected delete rollback */);
 				this.pendingData.splice(pendingEntryIndex, 1);
 				// Only emit if rolling back the delete actually results in a value becoming visible.
 				if (this.getOptimisticLocalValue(mapOp.key) !== undefined) {
@@ -676,7 +676,7 @@ export class MapKernel {
 				const pendingKeySet = pendingEntry.keySets.pop();
 				assert(
 					pendingKeySet !== undefined && pendingKeySet === typedLocalOpMetadata,
-					"Unexpected set rollback",
+					0xbf5 /* Unexpected set rollback */,
 				);
 				if (pendingEntry.keySets.length === 0) {
 					this.pendingData.splice(pendingEntryIndex, 1);
@@ -710,7 +710,7 @@ export class MapKernel {
 						pendingClear !== undefined &&
 							pendingClear.type === "clear" &&
 							pendingClear === localOpMetadata,
-						"Got a local clear message we weren't expecting",
+						0xbf6 /* Got a local clear message we weren't expecting */,
 					);
 				} else {
 					// Only emit for remote ops, we would have already emitted for local ops. Only emit if there
@@ -741,7 +741,7 @@ export class MapKernel {
 						pendingEntry !== undefined &&
 							pendingEntry.type === "delete" &&
 							pendingEntry === localOpMetadata,
-						"Got a local delete message we weren't expecting",
+						0xbf7 /* Got a local delete message we weren't expecting */,
 					);
 					this.pendingData.splice(pendingEntryIndex, 1);
 
@@ -779,12 +779,12 @@ export class MapKernel {
 					const pendingEntry = this.pendingData[pendingEntryIndex];
 					assert(
 						pendingEntry !== undefined && pendingEntry.type === "lifetime",
-						"Couldn't match local set message to pending lifetime",
+						0xbf8 /* Couldn't match local set message to pending lifetime */,
 					);
 					const pendingKeySet = pendingEntry.keySets.shift();
 					assert(
 						pendingKeySet !== undefined && pendingKeySet === localOpMetadata,
-						"Got a local set message we weren't expecting",
+						0xbf9 /* Got a local set message we weren't expecting */,
 					);
 					if (pendingEntry.keySets.length === 0) {
 						this.pendingData.splice(pendingEntryIndex, 1);

packages/dds/tree/src/core/tree/detachedFieldIndexCodecV2.ts

@@ -26,15 +26,15 @@ class MajorCodec implements IJsonCodec<Major> {
 	) {}
 
 	public encode(major: Major): EncodedRevisionTag | StableId {
-		assert(major !== undefined, "Unexpected undefined revision");
+		assert(major !== undefined, 0xbfb /* Unexpected undefined revision */);
 		const id = this.revisionTagCodec.encode(major);
 
 		if (id !== "root" && id < 0) {
 			/**
 			 * This code path handles the case where the major revision is not finalized.
 			 * This can happen the SharedTree is being attached to an already attached container.
 			 */
-			assert(major !== "root", "Major revision cannot be 'root'");
+			assert(major !== "root", 0xbfc /* Major revision cannot be 'root' */);
 			const long = this.idCompressor.decompress(major);
 			return long;
 		}
@@ -44,7 +44,7 @@ class MajorCodec implements IJsonCodec<Major> {
 	public decode(major: EncodedRevisionTag | StableId): RevisionTag {
 		assert(
 			major === "root" || (typeof major === "string" && isStableId(major)) || major >= 0,
-			"Expected root, stable, or final compressed id",
+			0xbfd /* Expected root, stable, or final compressed id */,
 		);
 		if (typeof major === "string" && isStableId(major)) {
 			return this.idCompressor.recompress(major);

packages/dds/tree/src/shared-tree/schematizingTreeView.ts

@@ -320,7 +320,7 @@ export class SchematizingSimpleTreeView<
 			assert(!slots.has(SimpleContextSlot), 0xa47 /* extra simple tree context */);
 			assert(
 				this.rootFieldSchema instanceof FieldSchemaAlpha,
-				"all field schema should be FieldSchemaAlpha",
+				0xbfa /* all field schema should be FieldSchemaAlpha */,
 			);
 			slots.set(
 				SimpleContextSlot,

packages/dds/tree/src/simple-tree/api/create.ts

@@ -47,7 +47,7 @@ export function createFromCursor<const TSchema extends ImplicitFieldSchema>(
 	contextForNewNodes?: Context,
 ): Unhydrated<TreeFieldFromImplicitField<TSchema>> {
 	const context = contextForNewNodes ?? getUnhydratedContext(schema);
-	assert(context.flexContext.isHydrated() === false, "Expected unhydrated context");
+	assert(context.flexContext.isHydrated() === false, 0xbfe /* Expected unhydrated context */);
 	const mapTrees = cursor === undefined ? [] : [unhydratedFlexTreeFromCursor(context, cursor)];
 
 	const rootFieldSchema = convertField(normalizeFieldSchema(schema));

packages/dds/tree/src/simple-tree/api/customTree.ts

@@ -142,13 +142,14 @@ export function customFromCursor<TChild>(
 					const storedKey = reader.getFieldKey();
 					let key: string;
 					if (!options.useStoredKeys) {
-						const viewSchema = schema.get(type) ?? fail("missing schema for type in cursor");
+						const viewSchema =
+							schema.get(type) ?? fail(0xbff /* missing schema for type in cursor */);
 						if (isObjectNodeSchema(viewSchema)) {
 							const propertyKey = viewSchema.storedKeyToPropertyKey.get(storedKey);
 							if (propertyKey === undefined) {
 								assert(
 									viewSchema.allowUnknownOptionalFields,
-									"found unknown field where not allowed",
+									0xc00 /* found unknown field where not allowed */,
 								);
 								// Skip unknown optional fields when using property keys.
 								return;

packages/runtime/container-runtime/src/blobManager/blobManager.ts

@@ -668,7 +668,7 @@ export class BlobManager {
 	 * @param metadata - op metadata containing storage and/or local IDs
 	 */
 	public reSubmit(metadata: Record<string, unknown> | undefined): void {
-		assert(isBlobMetadata(metadata), "Expected blob metadata for a BlobAttach op");
+		assert(isBlobMetadata(metadata), 0xc01 /* Expected blob metadata for a BlobAttach op */);
 		const { localId, blobId } = metadata;
 		// Any blob that we're actively trying to advance to attached state must have a
 		// pendingBlobs entry. Decline to resubmit for anything else.
@@ -682,7 +682,10 @@ export class BlobManager {
 	}
 
 	public processBlobAttachMessage(message: ISequencedMessageEnvelope, local: boolean): void {
-		assert(isBlobMetadata(message.metadata), "Expected blob metadata for a BlobAttach op");
+		assert(
+			isBlobMetadata(message.metadata),
+			0xc02 /* Expected blob metadata for a BlobAttach op */,
+		);
 		const { localId, blobId } = message.metadata;
 		const pendingEntry = this.pendingBlobs.get(localId);
 		if (pendingEntry?.abortSignal?.aborted) {

packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts

@@ -24,9 +24,6 @@ export const shortCodeMap = {
 	"0x010": "Received out of order storage op when there is an unackd clear message",
 	"0x011": "pendingMessageId is missing from the local client's operation",
 	"0x012": "pendingMessageId is missing from the local client's operation",
-	"0x013": "Received out of order op when there is an unackd clear message",
-	"0x014": "pendingMessageId is missing from the local client's operation",
-	"0x015": "pendingMessageId is missing from the local client's clear operation",
 	"0x017": "Trying to add invalid handle!",
 	"0x018": "Trying to insert handle into position with already valid handle!",
 	"0x019": "SharedMatrix.openUndo() supports at most a single IUndoConsumer.",
@@ -213,7 +210,6 @@ export const shortCodeMap = {
 	"0x120": "Undefined latency statistics for op (op send time)",
 	"0x126": "Expected createSubRequest url to include a leading slash",
 	"0x127": "dirty document event not set on replay",
-	"0x12a": "Missing blob id on metadata",
 	"0x12d": "Container Context should already be in attaching state",
 	"0x12e": "Container Context should already be in attached state",
 	"0x12f": "Container Runtime's summarize should always return a tree",
@@ -482,11 +478,6 @@ export const shortCodeMap = {
 	"0x2f5": "op create references must be SlideOnRemove",
 	"0x2f6": "SlideOnRemove references must be op created",
 	"0x2f9": "Unexpected accept op, client not in expectedSignoffs",
-	"0x2fa": "Unexpected pending message received",
-	"0x2fb": "pendingMessageId does not match",
-	"0x2fc": "Invalid localOpMetadata for clear",
-	"0x2fd": "pendingMessageId does not match",
-	"0x2fe": "Invalid localOpMetadata in submit",
 	"0x304": "Id cannot contain slashes",
 	"0x30e": "Id cannot contain slashes. DataStoreContext should have validated this.",
 	"0x30f": "Channel context ID cannot contain slashes",
@@ -533,12 +524,9 @@ export const shortCodeMap = {
 	"0x385": "For clarity and paranoid defense against adding future attachment states",
 	"0x386": "Must have pending blob entry for uploaded blob",
 	"0x387": "Must have pending blob entry for blob which failed to upload",
-	"0x38b": "Resubmitted ops must have metadata",
-	"0x38d": "blob must be uploaded before resubmitting BlobAttach op",
 	"0x38f": "local online BlobAttach op with no pending blob entry",
 	"0x390": "Must be attached to get GC data",
 	"0x391": "Redirect table size must match BlobManager's local ID count",
-	"0x394": "connect event delay must be cleared before propagating connect event",
 	"0x395": "it's one and the same thing",
 	"0x397": "Unexpected summary stage",
 	"0x39b": "localSeq provided for non-local client",
@@ -698,8 +686,6 @@ export const shortCodeMap = {
 	"0x509": "RuntimeAttributor must be initialized before getAttributionInfo can be called",
 	"0x50a": "Attributor tree should have op attributor summary blob.",
 	"0x50c": "freshness map out of sync",
-	"0x50d": "local ID not available on reSubmit",
-	"0x50e": "local ID not present in blob attach message",
 	"0x510": "No data store with specified id",
 	"0x511": "Only lz4 compression is supported",
 	"0x512": "Expecting empty message",
@@ -1008,7 +994,6 @@ export const shortCodeMap = {
 	"0x744": "The size of the sequenceMap must have one element more than the trunk",
 	"0x745": "The size of the trunkMetadata must be the same as the trunk",
 	"0x746": "sequence id has been evicted",
-	"0x747": "forest must be empty",
 	"0x751": "Object returned is not a valid marker",
 	"0x752": "Keys in map must be sorted.",
 	"0x753": "Cluster insert to final_space is out of order.",
@@ -1050,9 +1035,6 @@ export const shortCodeMap = {
 	"0x786": "mismatched indexes",
 	"0x787": "mismatched keys",
 	"0x78d": "required value must not be missing",
-	"0x790": "stashed blob should be attached",
-	"0x791": "Connect event delay must be canceled before subsequent connect event",
-	"0x792": "Must have clientId when connecting",
 	"0x793": "start and end cannot be undefined because they were not passed in as undefined",
 	"0x794": "start and end cannot be undefined because they were not passed in as undefined",
 	"0x795": "Data store runtime entryPoint does not have request",
@@ -1379,7 +1361,6 @@ export const shortCodeMap = {
 	"0x9b4": "Unexpected flex node implementation",
 	"0x9b5": "Inheritance should work",
 	"0x9b6": "No error to clear",
-	"0x9b7": "anchor set must be empty",
 	"0x9b8": "Inconsistent data: missing detached node entry",
 	"0x9b9": "Inconsistent data: missing node entry in latestRelevantRevision",
 	"0x9ba": "Unable to delete unknown entry",
@@ -1590,8 +1571,6 @@ export const shortCodeMap = {
 	"0xaca": "invalid field kind",
 	"0xacb": "invalid schema kind",
 	"0xacc": "Unknown SharedTree change type.",
-	"0xacd": "invalid input",
-	"0xace": "invalid input",
 	"0xacf": "invalid input",
 	"0xad1": "Unknown Shared Tree change type.",
 	"0xad2": "Expected branch to be related to trunk",
@@ -1684,7 +1663,6 @@ export const shortCodeMap = {
 	"0xb2c": "Mark type: NoopMarkType should not be encoded.",
 	"0xb2d": "Unable to split mark due to lengths",
 	"0xb2e": "missing schema for type in cursor",
-	"0xb2f": "missing property key",
 	"0xb30": "missing schema for type in cursor",
 	"0xb31": "missing enum value",
 	"0xb32": "node is out of schema",
@@ -1819,13 +1797,6 @@ export const shortCodeMap = {
 	"0xbc7": "Leaf schema associated with non-leaf tree node.",
 	"0xbc8": "Invalid inner node type",
 	"0xbc9": "All implementations of TreeNodeSchemaCore must also implement TreeNodeSchemaCorePrivate",
-	"0xbcb": "Rolling back unexpected op",
-	"0xbcc": "Processing unexpected local clear op",
-	"0xbcd": "Resubmitting unexpected local clear op",
-	"0xbce": "Processing unexpected local delete op",
-	"0xbcf": "Resubmitting unexpected local delete op",
-	"0xbd0": "Processing unexpected local set op",
-	"0xbd1": "Resubmitting unexpected local set op",
 	"0xbd4": "local must have metadata",
 	"0xbd5": "must have property manager to ack",
 	"0xbd6": "must be more in the list",
@@ -1854,6 +1825,22 @@ export const shortCodeMap = {
 	"0xbee": "all field schema should be FieldSchemaAlpha",
 	"0xbef": "A conversion from a FieldKind to a FlexFieldKind should exist",
 	"0xbf0": "A conversion from a FieldKind to a FlexFieldKind should exist",
-	"0xbf1": "Invalid realizer",
-	"0xbf2": "View schema must be a superset of the stored schema to allow upgrade"
+	"0xbf1": "Should never iterate to a key with undefined optimisticValue",
+	"0xbf2": "Unexpected clear rollback",
+	"0xbf3": "Unexpected pending data for set/delete op",
+	"0xbf4": "Unexpected delete rollback",
+	"0xbf5": "Unexpected set rollback",
+	"0xbf6": "Got a local clear message we weren't expecting",
+	"0xbf7": "Got a local delete message we weren't expecting",
+	"0xbf8": "Couldn't match local set message to pending lifetime",
+	"0xbf9": "Got a local set message we weren't expecting",
+	"0xbfa": "all field schema should be FieldSchemaAlpha",
+	"0xbfb": "Unexpected undefined revision",
+	"0xbfc": "Major revision cannot be 'root'",
+	"0xbfd": "Expected root, stable, or final compressed id",
+	"0xbfe": "Expected unhydrated context",
+	"0xbff": "missing schema for type in cursor",
+	"0xc00": "found unknown field where not allowed",
+	"0xc01": "Expected blob metadata for a BlobAttach op",
+	"0xc02": "Expected blob metadata for a BlobAttach op"
 };