refactor(client/dds): Enable type-only import/export linter rules and fix violations (#25051)

In preparation for these rules becoming default in the next release of
our eslint configuration.

Type-only imports offer a number of benefits and are considered a best
practice. More details can be found here:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html

Author: Josmithr

packages/dds/ink/.eslintrc.cjs

@@ -8,4 +8,17 @@ module.exports = {
 	parserOptions: {
 		project: ["./tsconfig.json", "./src/test/tsconfig.json"],
 	},
+	rules: {
+		// #region TODO: remove these once eslint-config-fluid has been updated to 5.8.0
+		"@typescript-eslint/consistent-type-exports": [
+			"error",
+			{ fixMixedExportsWithInlineTypeSpecifier: true },
+		],
+		"@typescript-eslint/consistent-type-imports": [
+			"error",
+			{ fixStyle: "inline-type-imports" },
+		],
+		"@typescript-eslint/no-import-type-side-effects": "error",
+		// #endregion
+	},
 };

packages/dds/ink/src/index.ts

@@ -6,7 +6,7 @@
 export { Ink } from "./ink.js";
 export { InkCanvas } from "./inkCanvas.js";
 export { InkFactory } from "./inkFactory.js";
-export {
+export type {
 	IClearOperation,
 	IColor,
 	ICreateStrokeOperation,

packages/dds/ink/src/ink.ts

@@ -3,26 +3,26 @@
  * Licensed under the MIT License.
  */
 
-import {
+import type {
 	IChannelAttributes,
 	IFluidDataStoreRuntime,
 	IChannelStorageService,
 } from "@fluidframework/datastore-definitions/internal";
 import {
 	MessageType,
-	ISequencedDocumentMessage,
+	type ISequencedDocumentMessage,
 } from "@fluidframework/driver-definitions/internal";
 import { readAndParse } from "@fluidframework/driver-utils/internal";
-import { ISummaryTreeWithStats } from "@fluidframework/runtime-definitions/internal";
+import type { ISummaryTreeWithStats } from "@fluidframework/runtime-definitions/internal";
 import {
-	IFluidSerializer,
+	type IFluidSerializer,
 	SharedObject,
 	createSingleBlobSummary,
 } from "@fluidframework/shared-object-base/internal";
 import { v4 as uuid } from "uuid";
 
 import { InkFactory } from "./inkFactory.js";
-import {
+import type {
 	IClearOperation,
 	ICreateStrokeOperation,
 	IInk,
@@ -33,7 +33,7 @@ import {
 	IPen,
 	IStylusOperation,
 } from "./interfaces.js";
-import { ISerializableInk, InkData } from "./snapshot.js";
+import { type ISerializableInk, InkData } from "./snapshot.js";
 
 /**
  * Filename where the snapshot is stored.

packages/dds/ink/src/inkCanvas.ts

@@ -3,7 +3,14 @@
  * Licensed under the MIT License.
  */
 
-import { IColor, IInk, IInkPoint, IInkStroke, IPen, IStylusOperation } from "./interfaces.js";
+import type {
+	IColor,
+	IInk,
+	IInkPoint,
+	IInkStroke,
+	IPen,
+	IStylusOperation,
+} from "./interfaces.js";
 
 interface IPoint {
 	x: number;

packages/dds/ink/src/inkFactory.ts

@@ -3,13 +3,13 @@
  * Licensed under the MIT License.
  */
 
-import {
+import type {
 	IChannelAttributes,
 	IChannelFactory,
 	IFluidDataStoreRuntime,
 	IChannelServices,
 } from "@fluidframework/datastore-definitions/internal";
-import { ISharedObject } from "@fluidframework/shared-object-base/internal";
+import type { ISharedObject } from "@fluidframework/shared-object-base/internal";
 
 import { Ink } from "./ink.js";
 import { pkgVersion } from "./packageVersion.js";

packages/dds/ink/src/interfaces.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import {
+import type {
 	ISharedObject,
 	ISharedObjectEvents,
 } from "@fluidframework/shared-object-base/internal";

packages/dds/ink/src/snapshot.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { IInkStroke } from "./interfaces.js";
+import type { IInkStroke } from "./interfaces.js";
 
 /**
  * Ink snapshot interface.

packages/dds/ink/src/test/ink.spec.ts

@@ -9,15 +9,15 @@ import { AttachState } from "@fluidframework/container-definitions";
 import {
 	MockContainerRuntimeFactory,
 	MockContainerRuntimeFactoryForReconnection,
-	MockContainerRuntimeForReconnection,
+	type MockContainerRuntimeForReconnection,
 	MockFluidDataStoreRuntime,
 	MockSharedObjectServices,
 	MockStorage,
 } from "@fluidframework/test-runtime-utils/internal";
 
 import { Ink } from "../ink.js";
 import { InkFactory } from "../inkFactory.js";
-import { IPen } from "../interfaces.js";
+import type { IPen } from "../interfaces.js";
 
 describe("Ink", () => {
 	let ink: Ink;

packages/dds/matrix/.eslintrc.cjs

@@ -12,6 +12,17 @@ module.exports = {
 	rules: {
 		"@typescript-eslint/no-shadow": "off",
 		"space-before-function-paren": "off", // Off because it conflicts with typescript-formatter
+		// #region TODO: remove these once eslint-config-fluid has been updated to 5.8.0
+		"@typescript-eslint/consistent-type-exports": [
+			"error",
+			{ fixMixedExportsWithInlineTypeSpecifier: true },
+		],
+		"@typescript-eslint/consistent-type-imports": [
+			"error",
+			{ fixStyle: "inline-type-imports" },
+		],
+		"@typescript-eslint/no-import-type-side-effects": "error",
+		// #endregion
 	},
 	overrides: [
 		{

packages/dds/shared-object-base/.eslintrc.cjs

@@ -8,4 +8,17 @@ module.exports = {
 	parserOptions: {
 		project: ["./tsconfig.json", "./src/test/tsconfig.json"],
 	},
+	rules: {
+		// #region TODO: remove these once eslint-config-fluid has been updated to 5.8.0
+		"@typescript-eslint/consistent-type-exports": [
+			"error",
+			{ fixMixedExportsWithInlineTypeSpecifier: true },
+		],
+		"@typescript-eslint/consistent-type-imports": [
+			"error",
+			{ fixStyle: "inline-type-imports" },
+		],
+		"@typescript-eslint/no-import-type-side-effects": "error",
+		// #endregion
+	},
 };