Skip to content

Commit e7b545b

Browse files
authored
XS⚠️ ◾ Release v1.7.4: Adding Code Signing (#619)
## Summary This changes includes updates to the release pipeline, the inclusion of code signing, a version bump for the `PR Metrics` tool, and minor formatting improvements to configuration files. Below is a summary of the most important changes: ### Release Pipeline Enhancements: * Updated the Azure DevOps release pipeline to use a static IP pool (`Azure-Pipelines-1ESPT-ExDShared-StaticIP`) and added a variable group for `PR Metrics`. (`.github/azure-devops/release.yml`, [.github/azure-devops/release.ymlL61-R65](diffhunk://#diff-25f998e817515523e95edd3b4e0eb06fad5909deec7e3d4b7d57f4912cb39349L61-R65)) * Introduced the `EsrpCodeSigning@5` task for signing `.vsix` files with ESRP code signing credentials. (`.github/azure-devops/release.yml`, [.github/azure-devops/release.ymlR95-R127](diffhunk://#diff-25f998e817515523e95edd3b4e0eb06fad5909deec7e3d4b7d57f4912cb39349R95-R127)) ### Version Updates: * Incremented the version of `PR Metrics` from `1.7.3` to `1.7.4` across multiple files, including `package.json`, `README.md`, `task.json`, and `vss-extension.json`. [[1]](diffhunk://#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L5-R5) [[2]](diffhunk://#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L130-R130) [[3]](diffhunk://#diff-65a89cd0ee689cbea9b9b09f50ce9df6f2af4d46936e7b185e82892495732362L5-R5) [[4]](diffhunk://#diff-22ee61dc67ccb9df83b5d37d8e3dc5031b27d5c5defb40371d3abdd043414ea7L6-R6) ### Configuration and Metadata Improvements: * Reformatted JSON arrays and objects in `vss-extension.json` for better readability. (`src/vss-extension.json`, [[1]](diffhunk://#diff-22ee61dc67ccb9df83b5d37d8e3dc5031b27d5c5defb40371d3abdd043414ea7L29-R37) [[2]](diffhunk://#diff-22ee61dc67ccb9df83b5d37d8e3dc5031b27d5c5defb40371d3abdd043414ea7L77-R85) * Updated the `userAgent` string in `gitHubReposInvoker.ts` and its associated test to reflect the new version. (`src/task/src/repos/gitHubReposInvoker.ts`, [[1]](diffhunk://#diff-f940089e58c7285d97fbb04b132d2827a8aaf024094dfcd7ba27351b7ae6b4a3L291-R291); `src/task/tests/repos/gitHubReposInvoker.spec.ts`, [[2]](diffhunk://#diff-b59d2e18f2819be803f73a843d0a11f129b972aef7c779280faa03ed5c63867dL37-R37) ## Testing ### Test Types - [ ] Unit tests - [X] Manual tests
1 parent 467d9c1 commit e7b545b

File tree

14 files changed

+52
-17
lines changed

14 files changed

+52
-17
lines changed

.github/azure-devops/release.yml

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,11 @@ extends:
5858

5959
- job: Release
6060
pool:
61-
name: Azure-Pipelines-1ESPT-ExDShared
61+
name: Azure-Pipelines-1ESPT-ExDShared-StaticIP
6262
os: linux
6363
image: ubuntu-latest
64+
variables:
65+
- group: PR Metrics
6466
steps:
6567
- checkout: self
6668
displayName: Checkout
@@ -90,6 +92,39 @@ extends:
9092
displayName: Release – Create
9193
workingDirectory: $(Build.SourcesDirectory)/release
9294

95+
- task: EsrpCodeSigning@5
96+
displayName: ESRP CodeSigning
97+
inputs:
98+
# Signing details are stored within the PR Metrics variable group.
99+
ConnectedServiceName: OmexCodeSigningESRP-Torus
100+
AppRegistrationClientId: $(CodeSigningAppRegistrationClientId)
101+
AppRegistrationTenantId: $(CodeSigningAppRegistrationTenantId)
102+
AuthAKVName: $(CodeSigningAuthAKVName)
103+
AuthSignCertName: $(CodeSigningAuthSignCertName)
104+
EsrpClientId: $(CodeSigningEsrpClientId)
105+
UseMSIAuthentication: true
106+
FolderPath: $(Build.SourcesDirectory)
107+
Pattern: "*.vsix"
108+
signConfigType: inlineSignParams
109+
inlineOperation: |-
110+
[
111+
{
112+
"KeyCode": "CP-500813",
113+
"OperationCode": "AdoExtensionSign",
114+
"ToolName": "sign",
115+
"ToolVersion": "1.0",
116+
"Parameters": {}
117+
},
118+
{
119+
"KeyCode": "CP-500813",
120+
"OperationCode": "AdoExtensionVerify",
121+
"ToolName": "sign",
122+
"ToolVersion": "1.0",
123+
"Parameters": {}
124+
}
125+
]
126+
SessionTimeout: 30
127+
93128
- task: AzureCLI@2
94129
displayName: Release – Publish
95130
inputs:

.github/workflows/release-phase-1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ jobs:
2121
with:
2222
major: 1
2323
minor: 7
24-
patch: 4
24+
patch: 5
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.7.3
1+
1.7.4

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ The default input values are expected to be appropriate for most builds.
127127
Therefore, the following YAML definition is recommended:
128128

129129
```YAML
130-
uses: microsoft/[email protected].3
130+
uses: microsoft/[email protected].4
131131
name: PR Metrics
132132
env:
133133
PR_METRICS_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -137,7 +137,7 @@ continue-on-error: true
137137
If you wish to modify the inputs, YAML akin the to the following can be used:
138138

139139
```YAML
140-
uses: microsoft/[email protected].3
140+
uses: microsoft/[email protected].4
141141
name: PR Metrics
142142
env:
143143
PR_METRICS_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

dist/index.mjs

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

dist/resources.resjson

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"$schema": "https://json.schemastore.org/resjson.json",
33
"loc.description": "Augments pull request titles to let reviewers quickly determine PR size and test coverage.",
44
"loc.description.comment": "The description of the task.",
5-
"loc.friendlyName": "PR Metrics v1.7.3",
5+
"loc.friendlyName": "PR Metrics v1.7.4",
66
"loc.friendlyName.comment": "The name of the task.",
77
"loc.helpMarkDown": "[More information](https://aka.ms/PRMetrics/README)",
88
"loc.helpMarkDown.comment": "The Markdown-formatted help text of the task.",

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"$schema": "https://json.schemastore.org/package.json",
33
"name": "prmetrics",
44
"publisher": "ms-omex",
5-
"version": "1.7.3",
5+
"version": "1.7.4",
66
"description": "Augments pull request titles to let reviewers quickly determine PR size and test coverage.",
77
"main": "dist/index.mjs",
88
"type": "module",

src/task/Strings/resources.resjson/en-US/resources.resjson

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"$schema": "https://json.schemastore.org/resjson.json",
33
"loc.description": "Augments pull request titles to let reviewers quickly determine PR size and test coverage.",
44
"loc.description.comment": "The description of the task.",
5-
"loc.friendlyName": "PR Metrics v1.7.3",
5+
"loc.friendlyName": "PR Metrics v1.7.4",
66
"loc.friendlyName.comment": "The name of the task.",
77
"loc.helpMarkDown": "[More information](https://aka.ms/PRMetrics/README)",
88
"loc.helpMarkDown.comment": "The Markdown-formatted help text of the task.",

src/task/src/repos/gitHubReposInvoker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ export default class GitHubReposInvoker extends BaseReposInvoker {
288288
this._logger.logWarning(`Octokit – ${message}`);
289289
},
290290
},
291-
userAgent: "PRMetrics/v1.7.3",
291+
userAgent: "PRMetrics/v1.7.4",
292292
};
293293

294294
if (RunnerInvoker.isGitHub) {

0 commit comments

Comments
 (0)