Skip to content

Commit 8a07b7b

Browse files
authored
Bump our telemetry package version (#39388)
Data collection is hard. Our internal package, which was last bumped around August 2024, mistakenly changed a load bearing string from `ETW_GROUP` to `MSPG_GROUP`. The former sets the ETW group id. The later does nothing. This PR represents bumping our dependency to the version with the fix. Considering that none of our data for CmdPal worked anyways, I took the opportunity to rename a bunch of our events that had totally generic names. Closes #38704 re: #38032 regressed around: #34078
1 parent f0a23ce commit 8a07b7b

File tree

5 files changed

+18
-5
lines changed

5 files changed

+18
-5
lines changed

.pipelines/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="Microsoft.PowerToys.Telemetry" version="2.0.2" />
3+
<package id="Microsoft.PowerToys.Telemetry" version="2.0.3" />
44
</packages>

src/modules/cmdpal/Microsoft.CmdPal.UI/Events/BeginInvoke.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// See the LICENSE file in the project root for more information.
44

55
using System.Diagnostics.Tracing;
6-
using Microsoft.CommandPalette.Extensions;
76
using Microsoft.PowerToys.Telemetry;
87
using Microsoft.PowerToys.Telemetry.Events;
98

@@ -13,4 +12,9 @@ namespace Microsoft.CmdPal.UI.Events;
1312
public class BeginInvoke : EventBase, IEvent
1413
{
1514
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
15+
16+
public BeginInvoke()
17+
{
18+
EventName = "CmdPal_BeginInvoke";
19+
}
1620
}

src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ColdLaunch.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// See the LICENSE file in the project root for more information.
44

55
using System.Diagnostics.Tracing;
6-
using Microsoft.CommandPalette.Extensions;
76
using Microsoft.PowerToys.Telemetry;
87
using Microsoft.PowerToys.Telemetry.Events;
98

@@ -13,4 +12,9 @@ namespace Microsoft.CmdPal.UI.Events;
1312
public class ColdLaunch : EventBase, IEvent
1413
{
1514
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
15+
16+
public ColdLaunch()
17+
{
18+
EventName = "CmdPal_ColdLaunch";
19+
}
1620
}

src/modules/cmdpal/Microsoft.CmdPal.UI/Events/OpenPage.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// See the LICENSE file in the project root for more information.
44

55
using System.Diagnostics.Tracing;
6-
using Microsoft.CommandPalette.Extensions;
76
using Microsoft.PowerToys.Telemetry;
87
using Microsoft.PowerToys.Telemetry.Events;
98

@@ -17,6 +16,8 @@ public class OpenPage : EventBase, IEvent
1716
public OpenPage(int pageDepth)
1817
{
1918
PageDepth = pageDepth;
19+
20+
EventName = "CmdPal_OpenPage";
2021
}
2122

2223
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;

src/modules/cmdpal/Microsoft.CmdPal.UI/Events/ReactivateInstance.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// See the LICENSE file in the project root for more information.
44

55
using System.Diagnostics.Tracing;
6-
using Microsoft.CommandPalette.Extensions;
76
using Microsoft.PowerToys.Telemetry;
87
using Microsoft.PowerToys.Telemetry.Events;
98

@@ -13,4 +12,9 @@ namespace Microsoft.CmdPal.UI.Events;
1312
public class ReactivateInstance : EventBase, IEvent
1413
{
1514
public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
15+
16+
public ReactivateInstance()
17+
{
18+
EventName = "CmdPal_ReactivateInstance";
19+
}
1620
}

0 commit comments

Comments
 (0)