Merge branch 'master' into users/rishabhmalikMS/verboseLogsKnobUpdate

Author: rishabhmalikMS

src/Agent.Listener/Configuration.Windows/AutoLogonManager.cs

@@ -208,7 +208,26 @@ private void RestartBasedOnUserInput(CommandSettings command)
                 //ExecuteAsync API of ProcessInvoker waits for the process to exit
                 var args = $@"-r -t 15 -c ""{msg}""";
                 Trace.Info($"Shutdown.exe path: {shutdownExePath}. Arguments: {args}");
-                Process.Start(shutdownExePath, $@"{args}");
+
+                try
+                {
+                    Process.Start(shutdownExePath, $@"{args}");
+                }
+                catch (System.ComponentModel.Win32Exception w32Ex)
+                {
+                    Trace.Error($"Failed to start shutdown process: Win32 error {w32Ex.NativeErrorCode}: {w32Ex.Message}");
+                    _terminal.WriteError($"Failed to restart machine automatically. Please restart manually. Error: {w32Ex.Message}");
+                }
+                catch (FileNotFoundException fnfEx)
+                {
+                    Trace.Error($"Shutdown executable not found at '{shutdownExePath}': {fnfEx.Message}");
+                    _terminal.WriteError($"Cannot find shutdown.exe. Please restart machine manually.");
+                }
+                catch (Exception ex)
+                {
+                    Trace.Error($"Unexpected error starting shutdown process: {ex.Message} {ex}");
+                    _terminal.WriteError($"Failed to restart machine automatically. Please restart manually. Error: {ex.Message}");
+                }
             }
             else
             {

src/Agent.Listener/Configuration/ConfigurationProvider.cs

@@ -369,6 +369,16 @@ private async Task<string> GetAzureSubscriptionIdAsync()
                         azureSubscriptionId = string.Empty;
                     }
                 }
+                catch (HttpRequestException httpEx)
+                {
+                    azureSubscriptionId = string.Empty;
+                    Trace.Info($"HTTP error accessing Azure IMDS: {httpEx.Message}");
+                }
+                catch (TaskCanceledException tcEx) when (tcEx.InnerException is System.TimeoutException)
+                {
+                    azureSubscriptionId = string.Empty;
+                    Trace.Info($"Timeout accessing Azure IMDS (not running on Azure): {tcEx.Message}");
+                }
                 catch (SocketException ex)
                 {
                     azureSubscriptionId = string.Empty;
@@ -379,6 +389,7 @@ private async Task<string> GetAzureSubscriptionIdAsync()
                     // An exception will be thrown if the Agent Machine is a non-Azure VM.
                     azureSubscriptionId = string.Empty;
                     Trace.Info($"GetAzureSubscriptionId ex: {ex.Message}");
+                    Trace.Info(ex.ToString());
                 }
             }
 

src/Agent.Listener/JobDispatcher.cs

@@ -1193,6 +1193,7 @@ await processChannel.SendAsync(
             catch (Exception ex)
             {
                 Trace.Warning($"Failed to send flush logs request to worker: {ex.Message}");
+                Trace.Warning(ex.ToString());
             }
 
             // Now wait for the additional 1 minute log flushing period

src/Agent.Listener/MessageListener.cs

@@ -8,6 +8,7 @@
 using Microsoft.VisualStudio.Services.Common;
 using System;
 using System.Collections.Generic;
+using System.Net.Http;
 using System.Net.Sockets;
 using System.Threading;
 using System.Threading.Tasks;

src/Agent.Listener/Program.cs

@@ -68,6 +68,7 @@ private static async Task<int> MainAsync(IHostContext context, string[] args)
                 {
                     terminal.WriteError(StringUtil.Loc("ErrorOccurred", e.Message));
                     trace.Error(StringUtil.Format($"Directory permission validation failed - insufficient permissions - {0}", e.Message));
+                    trace.Error(e);
                     return Constants.Agent.ReturnCode.TerminatedError;
                 }
 

src/Agent.Sdk/ProcessInvoker.cs

@@ -462,7 +462,7 @@ internal protected virtual async Task CancelAndKillProcessTree(bool killProcessO
             // Store proc reference locally to prevent race conditions with Dispose()
             Process proc = _proc;
             ArgUtil.NotNull(proc, nameof(_proc));
-            
+
             if (!killProcessOnCancel)
             {
                 bool sigint_succeed = await SendSIGINT(SigintTimeout);

src/Agent.Worker/ExecutionContext.cs

@@ -562,6 +562,7 @@ public void InitializeJob(Pipelines.AgentJobRequestMessage message, Cancellation
                 catch (Exception ex)
                 {
                     Trace.Warning($"Unable to generate workspace ID: {ex.Message}");
+                    Trace.Warning(ex.ToString());
                 }
             }
 

src/Agent.Worker/GitManager.cs

@@ -79,25 +79,29 @@ public async Task DownloadAsync(IExecutionContext executionContext, string versi
                 }
                 catch (OperationCanceledException) when (executionContext.CancellationToken.IsCancellationRequested)
                 {
-                    Trace.Info($"Git download has been cancelled.");
+                    Trace.Info("Git download cancelled by user");
+                    throw;
+                }
+                catch (UnauthorizedAccessException uaEx)
+                {
+                    Trace.Error($"Access denied writing Git executable to '{downloadGitPath}'");
+                    Trace.Error(uaEx);
                     throw;
                 }
                 catch (Exception ex)
                 {
                     retryCount++;
-                    Trace.Info("Failed to download Git");
+                    Trace.Info($"Git download failed (attempt {retryCount})");
                     Trace.Error(ex);
 
-                    if (retryCount > retryLimit)
+                    if (retryCount >= retryLimit)
                     {
-                        Trace.Info($"Retry limit to download Git has been reached.");
-                        break;
-                    }
-                    else
-                    {
-                        Trace.Info("Retry Git download in 10 seconds.");
-                        await Task.Delay(retryDelay, executionContext.CancellationToken);
+                        Trace.Error($"Failed to download Git after {retryLimit} attempts");
+                        throw;
                     }
+
+                    Trace.Info($"Retry Git download in {retryDelay / 1000} seconds");
+                    await Task.Delay(retryDelay, executionContext.CancellationToken);
                 }
             }
 

src/Agent.Worker/Handlers/PowerShellExeHandler.cs

@@ -118,6 +118,7 @@ public async Task RunAsync()
                 catch (Exception ex)
                 {
                     Trace.Info($"Unable to determine whether the script file is rooted: {ex.Message}");
+                    Trace.Info(ex.ToString());
                 }
 
                 Trace.Info($"Script file is rooted: {isScriptFileRooted}");

src/Agent.Worker/Handlers/ProcessHandler/ProcessHandler.cs

@@ -59,6 +59,7 @@ public async Task RunAsync()
             catch (Exception ex)
             {
                 Trace.Info($"Unable to determine whether the command is rooted: {ex.Message}");
+                Trace.Info(ex.ToString());
             }
 
             Trace.Info($"Command is rooted: {isCommandRooted}");