Skip to content

Hardcoded Resource Group Overrides Parameterization in deploy.ps1 #54

@indcoder

Description

@indcoder

The deploy.ps1 script has the Resource Group parameterized at the top of the file. However, in the script's final section (line 86), the Resource Group is hardcoded. This inconsistency negates the flexibility offered by parameterization and could lead to errors or deployment to unintended Resource Groups.
Steps to Reproduce:

  • Open the file.
  • Inspect the top of the file to see the Resource Group parameter.
  • Navigate to line 86, where the Resource Group is hardcoded.

Expected Behavior: The script should consistently utilize the parameterized Resource Group throughout, including the bottom-most section, to allow users to provide their desired Resource Group dynamically.
Proposed Solution: Replace the hardcoded Resource Group on line 86 with the parameterized value. Ensure that the entire script references the parameterized Resource Group consistently.

Image

az role assignment create --role "f6c7c914-8db3-469d-8ca1-694a8f32e121" --assignee-object-id $objectId --scope /subscriptions/$subId/resourceGroups/"rg-agent-workshop" --assignee-principal-type 'User'

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions