MakeUpperPtr should use length from ArgSlice instead of mistaken bytesRead calculation.

Author: prvyk

libs/server/Resp/Objects/ObjectStoreUtils.cs

@@ -114,7 +114,7 @@ public OperationDirection GetOperationDirection(ArgSlice input)
             if (input.ReadOnlySpan.SequenceEqual("RIGHT"u8))
                 return OperationDirection.Right;
             // Rare case: try making upper case and retry
-            MakeUpperCase(input.ptr);
+            MakeUpperCase(input.ptr, input.length);
             if (input.ReadOnlySpan.SequenceEqual("LEFT"u8))
                 return OperationDirection.Left;
             if (input.ReadOnlySpan.SequenceEqual("RIGHT"u8))

libs/server/Resp/Parser/RespCommand.cs

@@ -2768,7 +2768,7 @@ private RespCommand ArrayParseCommand(bool writeErrorOnFailure, ref int count, r
             var ptr = recvBufferPtr + readHead;
 
             // See if input command is all upper-case. If not, convert and try fast parse pass again.
-            if (MakeUpperCase(ptr))
+            if (MakeUpperCase(ptr, bytesRead - readHead))
             {
                 cmd = FastParseCommand(out count);
                 if (cmd != RespCommand.NONE)

libs/server/Resp/RespServerSession.cs

@@ -657,7 +657,7 @@ private void ProcessMessages()
         }
 
         // Make first command in string as uppercase
-        private bool MakeUpperCase(byte* ptr)
+        private bool MakeUpperCase(byte* ptr, int len)
         {
             // Assume most commands are already upper case.
             // Assume most commands are 2-8 bytes long.
@@ -672,7 +672,6 @@ private bool MakeUpperCase(byte* ptr)
             // Note that _all_ of these bytes are <= 95 in the common case
             // and there's no need to scan the whole string in those cases.
 
-            var len = bytesRead - readHead;
             if (len >= 12)
             {
                 var cmdLen = (uint)(*(ptr + 5) - '2');