Move functions to file where they're used.

Author: prvyk

libs/server/Resp/Parser/RespCommand.cs

@@ -8,6 +8,7 @@
 using System.Runtime.InteropServices;
 using System.Text;
 using Garnet.common;
+using Garnet.common.Parsing;
 using Microsoft.Extensions.Logging;
 using Tsavorite.core;
 
@@ -2972,6 +2973,76 @@ private static bool TryParseInlineCommandArguments(bool writeErrorOnFailure, out
             return false;
         }
 
+
+        ReadOnlySpan<byte> GetCommand(out bool success)
+        {
+            var ptr = recvBufferPtr + readHead;
+            var end = recvBufferPtr + bytesRead;
+
+            // Try the command length
+            if (!RespReadUtils.TryReadUnsignedLengthHeader(out int length, ref ptr, end))
+            {
+                success = false;
+                return default;
+            }
+
+            readHead = (int)(ptr - recvBufferPtr);
+
+            // Try to read the command value
+            ptr += length;
+            if (ptr + 2 > end)
+            {
+                success = false;
+                return default;
+            }
+
+            if (*(ushort*)ptr != CrLf)
+            {
+                RespParsingException.ThrowUnexpectedToken(*ptr);
+            }
+
+            var result = new ReadOnlySpan<byte>(recvBufferPtr + readHead, length);
+            readHead += length + 2;
+            success = true;
+
+            return result;
+        }
+
+        ReadOnlySpan<byte> GetUpperCaseCommand(out bool success)
+        {
+            var ptr = recvBufferPtr + readHead;
+            var end = recvBufferPtr + bytesRead;
+
+            // Try the command length
+            if (!RespReadUtils.TryReadUnsignedLengthHeader(out int length, ref ptr, end))
+            {
+                success = false;
+                return default;
+            }
+
+            readHead = (int)(ptr - recvBufferPtr);
+
+            // Try to read the command value
+            ptr += length;
+            if (ptr + 2 > end)
+            {
+                success = false;
+                return default;
+            }
+
+            if (*(ushort*)ptr != CrLf)
+            {
+                RespParsingException.ThrowUnexpectedToken(*ptr);
+            }
+
+            var result = new Span<byte>(recvBufferPtr + readHead, length);
+            readHead += length + 2;
+            success = true;
+
+            AsciiUtils.ToUpperInPlace(result);
+            return result;
+        }
+
         [MethodImpl(MethodImplOptions.NoInlining)]
         private void HandleAofCommitMode(RespCommand cmd)
         {

libs/server/Resp/RespServerSession.cs

@@ -1133,75 +1133,6 @@ private bool IsCommandArityValid(string cmdName, int arity, int count)
             return true;
         }
 
-        ReadOnlySpan<byte> GetCommand(out bool success)
-        {
-            var ptr = recvBufferPtr + readHead;
-            var end = recvBufferPtr + bytesRead;
-
-            // Try the command length
-            if (!RespReadUtils.TryReadUnsignedLengthHeader(out int length, ref ptr, end))
-            {
-                success = false;
-                return default;
-            }
-
-            readHead = (int)(ptr - recvBufferPtr);
-
-            // Try to read the command value
-            ptr += length;
-            if (ptr + 2 > end)
-            {
-                success = false;
-                return default;
-            }
-
-            if (*(ushort*)ptr != MemoryMarshal.Read<ushort>("\r\n"u8))
-            {
-                RespParsingException.ThrowUnexpectedToken(*ptr);
-            }
-
-            var result = new ReadOnlySpan<byte>(recvBufferPtr + readHead, length);
-            readHead += length + 2;
-            success = true;
-
-            return result;
-        }
-
-        ReadOnlySpan<byte> GetUpperCaseCommand(out bool success)
-        {
-            var ptr = recvBufferPtr + readHead;
-            var end = recvBufferPtr + bytesRead;
-
-            // Try the command length
-            if (!RespReadUtils.TryReadUnsignedLengthHeader(out int length, ref ptr, end))
-            {
-                success = false;
-                return default;
-            }
-
-            readHead = (int)(ptr - recvBufferPtr);
-
-            // Try to read the command value
-            ptr += length;
-            if (ptr + 2 > end)
-            {
-                success = false;
-                return default;
-            }
-
-            if (*(ushort*)ptr != MemoryMarshal.Read<ushort>("\r\n"u8))
-            {
-                RespParsingException.ThrowUnexpectedToken(*ptr);
-            }
-
-            var result = new Span<byte>(recvBufferPtr + readHead, length);
-            readHead += length + 2;
-            success = true;
-
-            AsciiUtils.ToUpperInPlace(result);
-            return result;
-        }
-
         /// <summary>
         /// Attempt to kill this session.
         ///