Skip to content

Commit 3ff4441

Browse files
committed
minor fix
1 parent 8ccaf09 commit 3ff4441

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

include/mscclpp/core.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,10 @@ struct EndpointConfig {
381381
/// These settings are only used when the transport is an InfiniBand type (IB0-IB7); they are ignored for other
382382
/// transports.
383383
struct Ib {
384-
static const int DefaultMaxCqSize = 1024;
385-
static const int DefaultMaxCqPollNum = 1;
386-
static const int DefaultMaxSendWr = 8192;
387-
static const int DefaultMaxWrPerSend = 64;
384+
static constexpr int DefaultMaxCqSize = 1024;
385+
static constexpr int DefaultMaxCqPollNum = 1;
386+
static constexpr int DefaultMaxSendWr = 8192;
387+
static constexpr int DefaultMaxWrPerSend = 64;
388388

389389
/// Maximum size of the completion queue.
390390
int maxCqSize;

python/csrc/algorithm.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ void register_algorithm(nb::module_& m) {
4848
.def(
4949
"execute",
5050
[](Algorithm& self, std::shared_ptr<Communicator> comm, uintptr_t input, uintptr_t output,
51-
size_t inputSize, size_t outputSize, DataType dtype, uintptr_t stream, std::shared_ptr<Executor> executor,
52-
std::unordered_map<std::string, uintptr_t> extras) {
51+
size_t inputSize, size_t outputSize, DataType dtype, uintptr_t stream,
52+
std::shared_ptr<Executor> executor, std::unordered_map<std::string, uintptr_t> extras) {
5353
return self.execute(comm, reinterpret_cast<const void*>(input), reinterpret_cast<void*>(output),
5454
inputSize, outputSize, dtype, reinterpret_cast<cudaStream_t>(stream), executor,
5555
extras);

src/unix_socket.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,7 @@ void UnixSocketServer::mainLoop(int listenUnixSockFd) {
229229
std::lock_guard<std::mutex> lock(mutex_);
230230
auto it = fdSet_.find(fd);
231231
if (it == fdSet_.end()) {
232+
WARN("Requested fd %d not found, size of fdSet_ is %zu", fd, fdSet_.size());
232233
throw Error("Requested fd not found: " + std::to_string(fd), ErrorCode::InvalidUsage);
233234
}
234235
fdToSend = *it;

0 commit comments

Comments
 (0)