-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[QNN-EP] - Tie HTP power config id lifetime to session #26457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
quic-calvnguy
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
CodeLinaro:dev/calvnguy/htp_power_config_id_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[QNN-EP] - Tie HTP power config id lifetime to session #26457
quic-calvnguy
wants to merge
8
commits into
microsoft:main
from
CodeLinaro:dev/calvnguy/htp_power_config_id_fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove PerThreadContext (Only used for id management) - Create ManagedHtpPowerConfigId to manage destruction of id - Only create one htp power config id per session
- Maintain mapping of thread ids and their respective thread-based power config settings - Avoids race condition in multi-threading situations
e2ffecb to
258e8b9
Compare
edgchen1
reviewed
Dec 4, 2025
d7df0ca to
349e10f
Compare
edgchen1
previously approved these changes
Dec 8, 2025
Contributor
|
@edgchen1 |
edgchen1
approved these changes
Dec 8, 2025
Contributor
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
One session can potentially be used on multiple threads for execution, and there is a set max number of htp power config ids that can be used at any given time. If enough sessions and enough threads are created, then the maximum number of power config ids can be reached easily (see ticket).
Additionally, all power configurations are available on a per-session basis. Therefore, there is no reason to have more than one power config id per session.
Removal of PerThreadContext is due to the fact that it was only used to contain and destroy the power config ids on thread termination. As such, there is no more need for PerThreadContext.