Skip to content

Conversation

@milderhc
Copy link
Contributor

@milderhc milderhc commented Oct 9, 2024

Motivation and Context

Description

Fixes: #240
Fixes: #242

Contribution Checklist

Copy link
Contributor

@dsgrieve dsgrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collections.unmodifiableList(tags) will throw a NPE if tags is null. The default constructor for Hotel passes null for tags.

A bigger question is why tags needs to be a copy. John asked only if it needs to be a copy. And why would tags be a copy and not the other lists?

@milderhc
Copy link
Contributor Author

Collections.unmodifiableList(tags) will throw a NPE if tags is null. The default constructor for Hotel passes null for tags.

A bigger question is why tags needs to be a copy. John asked only if it needs to be a copy. And why would tags be a copy and not the other lists?

I left it without copy. This Hotel class is only for integration tests anyways.

johnoliver
johnoliver previously approved these changes Oct 22, 2024
@milderhc milderhc merged commit 4fcab6a into microsoft:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java: Add AnyTagEqualsTo support JDBC stores Java: Add List.class to data supported types to support Tag Lists

3 participants