Skip to content

Commit 9917136

Browse files
authored
Adds Object Display Name to Visual Filter, Page Filter, and Report Filter categories (#988)
* Adds Object Display Name to Filter categories Brings 'Object Display Name' to Visual Filters, Page Filters, and Report Filters (this is the remaining 3 categories that allow you to rename a visual object, in addition to Visual Objects) * Adds DisplayName to Filter categories and adds fallback to Object Name
1 parent 848c7f7 commit 9917136

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/sempy_labs/report/_reportwrapper.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -772,6 +772,7 @@ def list_report_filters(self, extended: bool = False) -> pd.DataFrame:
772772
"Table Name": "str",
773773
"Object Name": "str",
774774
"Object Type": "str",
775+
"Object Display Name": "str",
775776
"Hidden": "bool",
776777
"Locked": "bool",
777778
"How Created": "str",
@@ -800,6 +801,7 @@ def list_report_filters(self, extended: bool = False) -> pd.DataFrame:
800801
"Table Name": properties[0],
801802
"Object Name": object_name,
802803
"Object Type": properties[1],
804+
"Object Display Name": flt.get("displayName", object_name),
803805
"Hidden": hidden,
804806
"Locked": locked,
805807
"How Created": how_created,
@@ -841,6 +843,7 @@ def list_page_filters(self, extended: bool = False) -> pd.DataFrame:
841843
"Table Name": "str",
842844
"Object Name": "str",
843845
"Object Type": "str",
846+
"Object Display Name": "str",
844847
"Hidden": "bool",
845848
"Locked": "bool",
846849
"How Created": "str",
@@ -875,6 +878,7 @@ def list_page_filters(self, extended: bool = False) -> pd.DataFrame:
875878
"Table Name": properties[0],
876879
"Object Name": object_name,
877880
"Object Type": properties[1],
881+
"Object Display Name": flt.get("displayName", object_name),
878882
"Hidden": hidden,
879883
"Locked": locked,
880884
"How Created": how_created,
@@ -918,6 +922,7 @@ def list_visual_filters(self, extended: bool = False) -> pd.DataFrame:
918922
"Table Name": "str",
919923
"Object Name": "str",
920924
"Object Type": "str",
925+
"Object Display Name": "str",
921926
"Hidden": "bool",
922927
"Locked": "bool",
923928
"How Created": "str",
@@ -957,6 +962,7 @@ def list_visual_filters(self, extended: bool = False) -> pd.DataFrame:
957962
"Table Name": properties[0],
958963
"Object Name": object_name,
959964
"Object Type": properties[1],
965+
"Object Display Name": flt.get("displayName", object_name),
960966
"Hidden": hidden,
961967
"Locked": locked,
962968
"How Created": how_created,
@@ -1532,7 +1538,6 @@ def find_entity_property_pairs(data, result=None, keys_path=None):
15321538
obj_full = f"{table_name}.{object_name}"
15331539
is_agg = properties[2]
15341540
format_value = format_mapping.get(obj_full)
1535-
obj_display = obj_display_mapping.get(obj_full)
15361541

15371542
if is_agg:
15381543
for k, v in format_mapping.items():
@@ -1550,7 +1555,7 @@ def find_entity_property_pairs(data, result=None, keys_path=None):
15501555
"Sparkline": properties[4],
15511556
"Visual Calc": properties[3],
15521557
"Format": format_value,
1553-
"Object Display Name": obj_display,
1558+
"Object Display Name": obj_display_mapping.get(obj_full, object_name),
15541559
}
15551560
)
15561561

0 commit comments

Comments
 (0)