auth: totally rewrite VSCodeAzureSubscriptionProvider
#2104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
commented
Oct 23, 2025
Contributor
Author
|
@danegsta suggested we switch to support proper pagination a la |
bwateratmsft
commented
Oct 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Azure authentication library to version 6.0.0-alpha.1 with a redesigned API surface. The changes introduce a cleaner separation of concerns by organizing contracts, providers, and utilities into distinct directories, and updating the AzureSubscriptionProvider interface with improved methods for account, tenant, and subscription management.
- Replaced
getSubscriptions()withgetAvailableSubscriptions()and added dedicated methods for accounts and tenants - Introduced new utility functions for PII screening, token expiration handling, and subscription deduplication
- Reorganized file structure into
contracts/,providers/, andutils/directories
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| auth/package.json | Bumped version to 6.0.0-alpha.1 and VS Code engine to 1.106.0 |
| auth/src/contracts/*.ts | Added new contract interfaces for accounts, tenants, subscriptions, and provider APIs |
| auth/src/providers/*.ts | Refactored subscription providers with new base and implementation classes |
| auth/src/utils/*.ts | Added utility functions for screening PII, token handling, and subscription deduplication |
| auth/test/utils/screen.test.ts | Added comprehensive tests for the new PII screening functionality |
| auth/README.md | Updated documentation to reflect new API methods |
Files not reviewed (1)
- auth/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was
linked to
issues
Nov 6, 2025
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the assumptions we made when originally creating this package are no longer true.
getAccounts()API nowgetSession()can often result inonDidChangeSessionsbeing fired unexpectedly, which made things likeisSignedIn()problematic (leading to event loops)This PR aims to address all of it. It also adds result caching by default, optional cancellation by token, and parallelizes requests when calling
getAvailableSubscriptions().It is very much a breaking change, so major versions will need to be updated.