Skip to content

Why the windows download needs an "alternative" #39

@connor4312

Description

@connor4312
        // This alternative strategy shouldn't be necessary but sometimes on Windows the file does not get closed,
        // so unzipping it fails, and I don't know why.

I think this is because the promise resolves on('finish' of the outFile. This is when contents have been written, but the file is not yet closed. Changing that to on('close' should resolve the issue.

Ref https://nodejs.org/api/fs.html#filehandlecreatewritestreamoptions

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions