Commit d69a79b
authored
Force custom editors in diff view to have 100% height wrappers (#96969)
Fix for #96968
This is a scoped fix for #96968.
The cause of the issue is the following:
1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM.
1. In split views, we try to lay the webview out over an element that has 0 height.
1. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show
This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but I've scoped my fix to just webviews1 parent c3b0ae5 commit d69a79b
File tree
1 file changed
+6
-0
lines changed- src/vs/workbench/contrib/webview/browser
1 file changed
+6
-0
lines changedLines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
100 | 106 | | |
101 | 107 | | |
102 | 108 | | |
| |||
0 commit comments