Skip to content

Commit 3a0ef17

Browse files
committed
Merge branch 'release/v2.5.4'
2 parents 8524394 + 207ef1e commit 3a0ef17

File tree

8 files changed

+29
-11
lines changed

8 files changed

+29
-11
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Provide additional fonts for you project, or even create your custom font with j
4646
##1. Provide the gradle dependency
4747
```gradle
4848
dependencies {
49-
compile 'com.mikepenz:iconics-core:2.5.3@aar'
49+
compile 'com.mikepenz:iconics-core:2.5.4@aar'
5050
}
5151
```
5252

@@ -62,7 +62,7 @@ compile 'com.mikepenz:weather-icons-typeface:2.0.10.1@aar'
6262
compile 'com.mikepenz:typeicons-typeface:2.0.7.1@aar'
6363
compile 'com.mikepenz:entypo-typeface:1.0.0.1@aar'
6464
compile 'com.mikepenz:devicon-typeface:2.0.0.1@aar'
65-
compile 'com.mikepenz:foundation-icons-typeface-typeface:3.0.0.1@aar'
65+
compile 'com.mikepenz:foundation-icons-typeface:3.0.0.1@aar'
6666
compile 'com.mikepenz:ionicons-typeface:2.0.1.1@aar'
6767
```
6868

@@ -300,7 +300,7 @@ https://play.google.com/store/apps/details?id=com.mikepenz.iconics.sample
300300

301301
#License
302302

303-
Copyright 2015 Mike Penz
303+
Copyright 2016 Mike Penz
304304

305305
Licensed under the Apache License, Version 2.0 (the "License");
306306
you may not use this file except in compliance with the License.

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ android {
1212
defaultConfig {
1313
minSdkVersion rootProject.ext.minSdkVersion
1414
targetSdkVersion rootProject.ext.targetSdkVersion
15-
versionCode 253
16-
versionName "2.5.3"
15+
versionCode 254
16+
versionName "2.5.4"
1717
enforceUniquePackageName false
1818
}
1919

app/src/main/res/layout/activity_automatic.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,14 @@
5050
android:layout_height="wrap_content"
5151
android:orientation="vertical">
5252

53+
<EditText
54+
android:id="@+id/editText"
55+
android:layout_width="wrap_content"
56+
android:layout_height="56dp"
57+
android:text="efgh{faw-adjust}ijk"
58+
android:textColor="@android:color/black"
59+
android:textSize="16sp" />
60+
5361
<TextView
5462
android:layout_width="match_parent"
5563
android:layout_height="wrap_content"

library-core/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ android {
77
defaultConfig {
88
minSdkVersion rootProject.ext.minSdkVersion
99
targetSdkVersion rootProject.ext.targetSdkVersion
10-
versionCode 253
11-
versionName "2.5.3"
10+
versionCode 254
11+
versionName "2.5.4"
1212
}
1313
buildTypes {
1414
release {

library-core/gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
# This option should only be used with decoupled projects. More details, visit
3333
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
3434
# org.gradle.parallel=true
35-
VERSION_NAME=2.5.3
36-
VERSION_CODE=253
35+
VERSION_NAME=2.5.4
36+
VERSION_CODE=254
3737

3838
POM_NAME=Android-Iconics Library
3939
POM_ARTIFACT_ID=iconics-core

library-core/src/main/java/com/mikepenz/iconics/Iconics.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,13 @@ public void build() {
243243
mappedFonts.put(font.getMappingPrefix(), font);
244244
}
245245

246+
//DO NOT STYLE EDITABLE (comes from EditText) as this causes bad issues with the cursor!
247+
/*
246248
if (view.getText() instanceof Editable) {
247249
Iconics.styleEditable(ctx, mappedFonts, (Editable) view.getText(), withStyles, withStylesFor);
248-
} else if (view.getText() instanceof Spanned) {
250+
} else
251+
*/
252+
if (view.getText() instanceof Spanned) {
249253
view.setText(Iconics.style(ctx, mappedFonts, (Spanned) view.getText(), withStyles, withStylesFor));
250254
} else {
251255
view.setText(Iconics.style(ctx, mappedFonts, new SpannableString(view.getText()), withStyles, withStylesFor));

library-core/src/main/java/com/mikepenz/iconics/context/IconicsFactory.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import android.text.TextWatcher;
99
import android.util.AttributeSet;
1010
import android.view.View;
11+
import android.widget.EditText;
1112
import android.widget.ImageView;
1213
import android.widget.TextView;
1314

@@ -49,6 +50,11 @@ void onViewCreatedInternal(View view, final Context context, AttributeSet attrs)
4950
}
5051

5152
a.recycle();
53+
} else if (view instanceof EditText) {
54+
//handle iconics
55+
new Iconics.IconicsBuilder().ctx(context).on((TextView) view).build();
56+
57+
//for an editText we only style initial as styling the Editable causes problems!
5258
} else if (view instanceof TextView) {
5359
//handle iconics
5460
new Iconics.IconicsBuilder().ctx(context).on((TextView) view).build();

library-core/src/main/res/values/library_androidiconics_strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
This library allows you to include vector icons everywhere in your project. No limits are given. Scale with no limit, use any Color at any time, provide a contour, and many additional customizations
2626
]]>
2727
</string>
28-
<string name="library_AndroidIconics_libraryVersion">2.5.3</string>
28+
<string name="library_AndroidIconics_libraryVersion">2.5.4</string>
2929
<string name="library_AndroidIconics_libraryWebsite">https://github.com/mikepenz/Android-Iconics</string>
3030
<string name="library_AndroidIconics_licenseId">apache_2_0</string>
3131
<string name="library_AndroidIconics_isOpenSource">true</string>

0 commit comments

Comments
 (0)