strings: broken -n NUM validation

mknos · web-flow · commit 63a838a13561 · 2025-03-06T09:15:54.000+08:00
* The number passed to -n can be more than 1 digit

%/usr/bin/strings -n150 /bin/bash | md5sum &amp;&amp; perl strings -n150 /bin/bash | md5sum
18cf22fcd75586ea1c6e5411c338c11d  -
18cf22fcd75586ea1c6e5411c338c11d  -
diff --git a/bin/strings b/bin/strings
@@ -72,7 +72,7 @@ sub usage {
 
 getopts( 'afon:t:' ) or usage();
 if (defined $opt_n) {
-    if ($opt_n !~ m/\A[0-9]\Z/ || $opt_n == 0) {
+    if ($opt_n !~ m/\A[0-9]+\Z/ || $opt_n == 0) {
         warn "$Program: invalid minimum string length '$opt_n'\n";
         exit EX_FAILURE;
     }

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ sub usage {`
`72`	`72`
`73`	`73`	`getopts( 'afon:t:' ) or usage();`
`74`	`74`	`if (defined $opt_n) {`
`75`		`- if ($opt_n !~ m/\A[0-9]\Z/ \|\| $opt_n == 0) {`
	`75`	`+ if ($opt_n !~ m/\A[0-9]+\Z/ \|\| $opt_n == 0) {`
`76`	`76`	`warn "$Program: invalid minimum string length '$opt_n'\n";`
`77`	`77`	`exit EX_FAILURE;`
`78`	`78`	`}`